Fixed a build error on mac + cuda (only libstdc++ is supported by nvcc) #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is not compatible with CUDA so pcl fails to build unless the previous stdlib is specified explicitly
jspricke
added a commit
that referenced
this pull request
Jan 28, 2014
Fixed a build error on mac + cuda (only libstdc++ is supported by nvcc)
Contributor
|
This is really bad! You have to use stdc++ for every project that uses PCL in Mac and the same for the dependencies. I think it would be better to disable CUDA if using libc++ and enable it when using libstdc++. |
Author
|
I agree - if one wants to compile without CUDA this is ugly. Maybe an additional CUDA-test in the if-clause for adding libstdc++ if CUDA is enabled and not touch anything otherwise? |
Author
|
The reason why the libstdc++ flag is ugly to specify manually from command line is that the necessary flags on line 151 are only added if cxxflags is empty, so they must in that case also be included by anyone building on Mac with CUDA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OSX 10.9, libc++ is now the default standard library on Mac. libc++ is not compatible with CUDA so pcl fails to build unless the previous stdlib is specified explicitly