Replace pcl_isnan, pcl_isfinite and pcl_isinf by C++11 methods#2798
Replace pcl_isnan, pcl_isfinite and pcl_isinf by C++11 methods#2798SergioRAgostinho merged 5 commits intoPointCloudLibrary:masterfrom
Conversation
|
Compile issue is raised here: pcl/common/include/pcl/common/point_tests.h Lines 98 to 102 in 99a5b28 Reason: I could simply change code to: But this should always return true, because it is and int type and can't store and infinite value, or? So maybe this is better fix: What do you think? |
|
Sure, integer can not be infinite; that test makes no sense. Just return |
|
Found a lot of more senseless calls to these functions. Thanks for this compile issue MSVC to find this stupid calls 😄 Btw: I reordered template specialization lexicographically. |
69eb66c to
1f363c7
Compare
taketwo
left a comment
There was a problem hiding this comment.
The last commit has too many unrelated changes in my opinion. Could you please split it while addressing comments?
They are not unrelated. This are all MSVC fixes (Azure failed before these changes). |
6db1fce to
d6b7134
Compare
2bf59eb to
1c03c36
Compare
…VC compile issue due to missing IntegralType overloading.
1c03c36 to
21df03e
Compare
SergioRAgostinho
left a comment
There was a problem hiding this comment.
As usual, thanks for the effort.
according to: * **[modernization]** Deprecate `pcl_isnan`, `pcl_isfinite`, and `pcl_isinf` in favor of `std` methods [[#2798](PointCloudLibrary/pcl#2798), [#3457](PointCloudLibrary/pcl#3457)]
No description provided.