Skip to content

Conversation

@Anon8281
Copy link

@Anon8281 Anon8281 commented Jun 26, 2023

Pull Request

Type

  • Internal change (Doesn't affect end-user).
  • External change (Does affect end-user).
  • Wiki (Changes towards the [Wiki]).
  • Other: __________

Description

Added Folia support using https://github.com/Anon8281/UniversalScheduler

@Emibergo02
Copy link

@PiggyPiglet @darbyjack are you considering to merge this PR?

@DarkyG2
Copy link

DarkyG2 commented Sep 24, 2023

Been using it for a while and I have 0 issues with it on prod

@ewof
Copy link

ewof commented Sep 29, 2023

same had no issues after using for months

@Andre601 Andre601 mentioned this pull request Oct 4, 2023
2 tasks
@RanMinecraft
Copy link

same had no issues after using for months

+1

@Q2297045667
Copy link

Will this PR be supported in versions 1.20.3 and 1.21 in the future?

@Netherwhal
Copy link

I am getting the following build error:

10:22:07 Could not determine the dependencies of task ':shadowJar'.
10:22:07 > Could not resolve all dependencies for configuration ':runtimeClasspath'.
10:22:07    > Could not find com.github.Anon8281:UniversalScheduler:0.1.3.
10:22:07      Searched in the following locations:
10:22:07        - https://oss.sonatype.org/content/repositories/snapshots/com/github/Anon8281/UniversalScheduler/0.1.3/UniversalScheduler-0.1.3.pom
10:22:07        - https://repo.maven.apache.org/maven2/com/github/Anon8281/UniversalScheduler/0.1.3/UniversalScheduler-0.1.3.pom
10:22:07        - file:/home/ec2-user/.m2/repository/com/github/Anon8281/UniversalScheduler/0.1.3/UniversalScheduler-0.1.3.pom
10:22:07        - https://repo.codemc.org/repository/maven-public/com/github/Anon8281/UniversalScheduler/0.1.3/UniversalScheduler-0.1.3.pom
10:22:07        - https://hub.spigotmc.org/nexus/content/repositories/snapshots/com/github/Anon8281/UniversalScheduler/0.1.3/UniversalScheduler-0.1.3.pom
10:22:07      Required by:
10:22:07          project :

@Anon8281
Copy link
Author

Sorry guys, forgot about repo

@Commandcracker
Copy link

The TPS Calculation needs to change I recommend adding placeholders for

  • Lowest Region TPS
  • Median Region TPS (I think this should replace normal server_tps on Folia)
  • Highest Region TPS
  • Player Region TPS
  • (Maybe Specific Region TPS, but I don't think this is needed)

@iGabyTM
Copy link
Member

iGabyTM commented Jan 21, 2024

The TPS Calculation needs to change I recommend adding placeholders for

  • Lowest Region TPS
  • Median Region TPS (I think this should replace normal server_tps on Folia)
  • Highest Region TPS
  • Player Region TPS
  • (Maybe Specific Region TPS, but I don't think this is needed)

This should be part of a folia expansion, I don't think is worth to add extra placeholders in the server expansion that will be available only for folia.

@Commandcracker
Copy link

The TPS Calculation needs to change I recommend adding placeholders for

  • Lowest Region TPS
  • Median Region TPS (I think this should replace normal server_tps on Folia)
  • Highest Region TPS
  • Player Region TPS
  • (Maybe Specific Region TPS, but I don't think this is needed)

This should be part of a folia expansion, I don't think is worth to add extra placeholders in the server expansion that will be available only for folia.

If so, then I think the server_tps should be replaced with the Median Region TPS on Folia.
IDK what it currently returns, but it's probably always 0 or 20.

@Anon8281 Anon8281 requested a review from Andre601 January 21, 2024 21:45
@Commandcracker
Copy link

I tested it and the server_tps is always 20

@Commandcracker
Copy link

Should I make an issue on Server-Expansion about the TPS when this PR is merged ?

Copy link
Collaborator

@Andre601 Andre601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine by me.

@Funny-cube Funny-cube mentioned this pull request Jan 27, 2024
2 tasks
@HydrolienF
Copy link

Is this merge request sill being reviewed ?
I would love to have an 1.20.6 Folia compatible PlaceholderAPI.

@Potenza7
Copy link

Potenza7 commented Aug 1, 2024

Folia dev 1.21 version has been released. Can you add 1.21 support?

@Anon8281
Copy link
Author

Anon8281 commented Aug 1, 2024

Folia dev 1.21 version has been released. Can you add 1.21 support?

Is there any issues running the current version of the plugin on 1.21?

@Potenza7
Copy link

Potenza7 commented Aug 1, 2024

Folia dev 1.21 version has been released. Can you add 1.21 support?

Is there any issues running the current version of the plugin on 1.21?

I made this comment without trying it. I just tried it and it works fine!

@ammodev
Copy link

ammodev commented Oct 14, 2024

I know you still have pending reviews but is there a way of merging this soon™️?

@OoLunar
Copy link

OoLunar commented Nov 10, 2024

If you could merge this soon, that'd be appreciated! Everything seems fine by the glance of things?

@Panda260
Copy link

merge?

@TheBjoRedCraft
Copy link

Any updates about merging?

@Ownercz
Copy link

Ownercz commented Mar 17, 2025

Any chance to get this merged please?

@StrangeOne101
Copy link

Only issue I had was PAPI passing a null player object to placeholder expansions. But other than that, works fine!

@liforra
Copy link

liforra commented Apr 25, 2025

when merge?

@Cartrigger
Copy link

why isn't this merged?

@PiggyPiglet
Copy link
Member

Hi @Anon8281

We can definitely look into merging this seeing as feedback is ultimately positive. One thing though, I'm not a huge fan of another dependency for security reasons. I'll be able to merge this if the implementation is built into PAPI

PiggyPiglet added a commit that referenced this pull request Jul 1, 2025
Merge UniversalScheduler (Folia Support) #980
@PiggyPiglet
Copy link
Member

Merged in #1127

@PiggyPiglet PiggyPiglet closed this Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.