-
Notifications
You must be signed in to change notification settings - Fork 260
Folia support #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folia support #980
Conversation
|
@PiggyPiglet @darbyjack are you considering to merge this PR? |
|
Been using it for a while and I have 0 issues with it on prod |
|
same had no issues after using for months |
+1 |
|
Will this PR be supported in versions 1.20.3 and 1.21 in the future? |
|
I am getting the following build error: |
|
Sorry guys, forgot about repo |
|
The TPS Calculation needs to change I recommend adding placeholders for
|
This should be part of a |
If so, then I think the server_tps should be replaced with the Median Region TPS on Folia. |
|
I tested it and the server_tps is always 20 |
|
Should I make an issue on Server-Expansion about the TPS when this PR is merged ? |
Andre601
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine by me.
|
Is this merge request sill being reviewed ? |
# Conflicts: # build.gradle.kts
|
Folia dev 1.21 version has been released. Can you add 1.21 support? |
Is there any issues running the current version of the plugin on 1.21? |
I made this comment without trying it. I just tried it and it works fine! |
|
I know you still have pending reviews but is there a way of merging this soon™️? |
|
If you could merge this soon, that'd be appreciated! Everything seems fine by the glance of things? |
|
merge? |
|
Any updates about merging? |
|
Any chance to get this merged please? |
|
Only issue I had was PAPI passing a null player object to placeholder expansions. But other than that, works fine! |
|
when merge? |
|
why isn't this merged? |
|
Hi @Anon8281 We can definitely look into merging this seeing as feedback is ultimately positive. One thing though, I'm not a huge fan of another dependency for security reasons. I'll be able to merge this if the implementation is built into PAPI |
Merge UniversalScheduler (Folia Support) #980
|
Merged in #1127 |
Pull Request
Type
Description
Added Folia support using https://github.com/Anon8281/UniversalScheduler