Skip to content

Fix issue with invalid placeholder pattern lowercasing text #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PiggyPiglet merged 2 commits into from
Dec 13, 2021
Merged

Fix issue with invalid placeholder pattern lowercasing text #667

PiggyPiglet merged 2 commits into from
Dec 13, 2021

Conversation

@Andre601
Copy link
Collaborator

@Andre601 Andre601 commented Jul 14, 2021

Pull Request

Type

  • Internal change (Doesn't affect end-user).
  • External change (Does affect end-user).
  • Wiki (Changes towards the Wiki).
  • Other: __________

Description

There seems to be an issue with PAPI lowercasing text when it contains % which triggers the CharReplacer and results in it returning a lowercase text for when the Placeholder Pattern isn't matched.

See these lines:

PlaceholderAPI/src/main/java/me/clip/placeholderapi/replacer/CharsReplacer.java

Lines 129 to 136 in 4127550

final String identifierString = identifier.toString().toLowerCase();
final String parametersString = parameters.toString();
identifier.setLength(0);
parameters.setLength(0);
if (oopsitsbad) {
builder.append(closure.head).append(identifierString);

Closes #666

@Andre601 Andre601 added the Type: Enhancement New feature or request label Aug 8, 2021
@Andre601 Andre601 added Type: Bugfix This fixes an existing bug in PlaceholderAPI. and removed Type: Enhancement New feature or request labels Oct 9, 2021
@matthewchoiyiuhei
Copy link

matthewchoiyiuhei commented Dec 9, 2021

Please merge this, it means a lot to us. Thank you so much!

@PiggyPiglet PiggyPiglet changed the title Fix issue with invalid placeholder pattern lowecasing text Fix issue with invalid placeholder pattern lowercasing text Dec 13, 2021
@PiggyPiglet PiggyPiglet merged commit e3602e5 into development Dec 13, 2021
@PiggyPiglet PiggyPiglet deleted the fix/666-lowercase-issues branch December 13, 2021 07:03
@Andre601 Andre601 mentioned this pull request Dec 16, 2021
Closed
4 tasks
darbyjack pushed a commit that referenced this pull request Dec 20, 2021
@PiggyPiglet @darbyjack
Merge pull request #667 from PlaceholderAPI/fix/666-lowercase-issues
cfd2899 
Fix issue with invalid placeholder pattern lowercasing text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PiggyPiglet PiggyPiglet PiggyPiglet approved these changes

@extendedclip extendedclip Awaiting requested review from extendedclip extendedclip is a code owner

Assignees

No one assigned

Labels

Type: Bugfix This fixes an existing bug in PlaceholderAPI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Andre601 @matthewchoiyiuhei @PiggyPiglet