Fixing issues for logging when Expansion doesn't contain any classes. #517
Conversation
|
In the non null filter, we need to log an error saying which was null, so the user can remove that expansion or fix it. |
Which one do you mean with "non null filter"? The |
yeah L#328 LocalExpansionManager |
The bigger issue here is, that we can't even log properly as a null object such as the file's name is enough to break things. |
|
Additionally does the Objects::nonNull check not work either as the stream there is only looking for the jar files to exist (which they do) but doesn't do checks for if the file is actually valid and not corrupted. |
Pull Request
Type
Description
Closes #515
Closes #516
When an expansion doesn't contain any class files (Being it malformed download or broken build) will PlaceholderAPI throw an exception when it attempts to log the failed loading of an expansion, essentially breaking the logging. Please see #515 for full context.
This Pull request is NOT finished yet as we still need to find a solution to fix this issue while still logging the failed load of an expansion.
In addition have some of the lines been updated to not provide missinformation (Often such errors happen due to a missing dependency and not an outdated expansion)