-
Notifications
You must be signed in to change notification settings - Fork 260
Closed
Labels
Type: EnhancementNew feature or requestNew feature or request
Description
Feature Request
Type
- New function for PlaceholderAPI.
A new function that developers could use. - Change to code (Internal).
Changes to code that won't affect the end-user. - Change to code (External).
Changes to code that will affect the end-user (breaks stuff). - Other: __________
Description
The current logging seems a bit odd to me.
For example is here an example of the register method in the LocalExpansionManager:
PlaceholderAPI/src/main/java/me/clip/placeholderapi/expansion/manager/LocalExpansionManager.java
Lines 170 to 172 in 4074192
| plugin.getLogger().severe("expansion class " + clazz.getSimpleName() + " is outdated: \n" + | |
| "Failed to load due to a [" + ex.getClass().getSimpleName() + "], attempted to use " + ex | |
| .getMessage()); |
Why use ex.getMessage()? If it's an exception then it should be thrown for clearance as to where it happened.
And instead of "expansion class xxx is outdated" have something like "Exception while registering expansion xxx (Is it outdated?)"
NicBOMB
Metadata
Metadata
Assignees
Labels
Type: EnhancementNew feature or requestNew feature or request