Skip to content

fix for all expansions stop loading after an exception is thrown (#1094) #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PiggyPiglet merged 2 commits into from
Mar 30, 2025
Merged

fix for all expansions stop loading after an exception is thrown (#1094) #1095

PiggyPiglet merged 2 commits into from
Mar 30, 2025

Conversation

@Kqliber
Copy link
Collaborator

@Kqliber Kqliber commented Jan 8, 2025

Pull Request

Type

  • Internal change (Doesn't affect end-user).
  • External change (Does affect end-user).
  • Wiki (Changes towards the Wiki).
  • Other: __________

Description

Closes #1094

NaysKutzu
NaysKutzu approved these changes Jan 17, 2025
View reviewed changes
Copy link

@NaysKutzu NaysKutzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Approve

@PiggyPiglet PiggyPiglet merged commit 33d1009 into PlaceholderAPI:master Mar 30, 2025
@Andre601 Andre601 mentioned this pull request Apr 9, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BlitzOffline BlitzOffline BlitzOffline approved these changes

@PiggyPiglet PiggyPiglet Awaiting requested review from PiggyPiglet PiggyPiglet is a code owner

@darbyjack darbyjack Awaiting requested review from darbyjack darbyjack is a code owner

+2 more reviewers

@NaysKutzu NaysKutzu NaysKutzu approved these changes

@Skullians Skullians Skullians approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

External expansions stop loading after an exception is thrown

5 participants

@Kqliber @BlitzOffline @NaysKutzu @Skullians @PiggyPiglet