Skip to content

External expansions stop loading after an exception is thrown #1094

@Kqliber

Description

@Kqliber

Confirmation

  • My issue isn't already found on the Issue tracker.
  • My issue is about PlaceholderAPI and not any expansion or external plugin
  • The issue isn't already fixed in a Spigot Release or Development Build.
  • The Common Issues page doesn't mention this issue.

Type

Plugin Bug

What happens?

When one expansion fails to load (for whatever reason) and throws an exception, all other expansions followed are not attempted to be loaded

Expected Behaviour

All other expansions should still be loaded, with just the 1 expansion failing to load

How to Reproduce

Generate an exception during the file operations when registering an external expansion

/papi dump Output

N/A

Console Log

No response

Errors

No response

Additional Info

This is because of this line here

When the method is called and an exception occurs, the mapping operation is abandoned

return Arrays.stream(files)
        .map(this::findExpansionInFile)
        .collect(Futures.collector());
        

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type: Issue (Unconfirmed)Issue is not reproducable and therefore not confirmed to exist.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions