Backport bug fixes for 3.0.2#1550
Merged
Merged
Conversation
Some internal code in Mono.Addins assumes the header's ContentLength property is never null, but this is not the case for gzipped responses from Github's server. This started happening recently so it may have been a change on Github's end. The workaround is to register our own HttpClient provider which disables gzip compression in our requests. Fixes: #1542 (cherry picked from commit d0442c1)
The Red toggle was actually affecting the blue color in some code paths, and vice versa, because the channel indices for ColorBgra are also used to index into the mask. (cherry picked from commit 9412756)
This is recommended by upstream (https://gitlab.gnome.org/GNOME/gtk/-/issues/7214) and should fix issues with a Vulkan DLL being picked up which doesn't match GTK's requirements Bug: #1497 (cherry picked from commit 54a53a1)
SetAccelsForAction() is quite expensive (I suspect it needs to go through and update any widgets which might be using the action), so this should be done once up front rather than when rebuilding the menu. This improves the performance of opening 20 documents at once from 17s to 400ms Bug: #1574 (cherry picked from commit 776ef8a)
- Don't use WindowActions to change the active document. This is UI code, and the WorkspaceManager is the correct place to do this. Instead, WindowActions should just update its menu according to the workspace's events - Add an event which is fired before the active document is changed. This allows the tool manager to commit the current tool, decoupling the two - Use the active_document_index as the signal for whether there are open documents, since the document created event is fired before the document is activated - Remove the action manager parameter which is no longer needed (cherry picked from commit b87cfac)
…e open This improves the performance of opening 50 documents from ~14s to 1.5s (cherry picked from commit 329e4a8)
This was from the docking layout in Pinta 1.7, and isn't used anymore. (This was removed in the master branch with the canvas rewrite, so there's no need to update this code to work with the changes for tracking the active document)
Contributor
|
@cameronwhite I forgot to suggest #1489 to be backported as well, my bad. Maybe for 3.0.3? |
Member
Author
|
Sure, that seems reasonable to backport. I'll probably do a 3.0.3 as soon as the Mac icon bug can be figured out |
Contributor
#1500 probably is also a good candidate for 3.0.3 btw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.