Skip to content

Backport bug fixes for 3.0.2#1550

Merged
cameronwhite merged 10 commits into
release-3.0from
backport/3.0.2
Jul 6, 2025
Merged

Backport bug fixes for 3.0.2#1550
cameronwhite merged 10 commits into
release-3.0from
backport/3.0.2

Conversation

@cameronwhite

@cameronwhite cameronwhite commented Jun 15, 2025

Copy link
Copy Markdown
Member

Some internal code in Mono.Addins assumes the header's ContentLength property is never null, but this is not the case for gzipped responses from Github's server. This started happening recently so it may have been a change on Github's end.
The workaround is to register our own HttpClient provider which disables gzip compression in our requests.

Fixes: #1542
(cherry picked from commit d0442c1)
The Red toggle was actually affecting the blue color in some code paths, and vice versa, because the channel indices for ColorBgra are also used to index into the mask.

(cherry picked from commit 9412756)
This is recommended by upstream (https://gitlab.gnome.org/GNOME/gtk/-/issues/7214) and should fix issues with a Vulkan DLL being picked up which doesn't match GTK's requirements

Bug: #1497
(cherry picked from commit 54a53a1)
SetAccelsForAction() is quite expensive (I suspect it needs to go through and update any widgets which might be using the action), so this should be done once up front rather than when rebuilding the menu.

This improves the performance of opening 20 documents at once from 17s to 400ms

Bug: #1574
(cherry picked from commit 776ef8a)
- Don't use WindowActions to change the active document. This is UI code, and the WorkspaceManager is the correct place to do this. Instead, WindowActions should just update its menu according to the workspace's events

- Add an event which is fired before the active document is changed. This allows the tool manager to commit the current tool, decoupling the two

- Use the active_document_index as the signal for whether there are open documents, since the document created event is fired before the document is activated

- Remove the action manager parameter which is no longer needed

(cherry picked from commit b87cfac)
…e open

This improves the performance of opening 50 documents from ~14s to 1.5s

(cherry picked from commit 329e4a8)
This was from the docking layout in Pinta 1.7, and isn't used anymore. (This was removed in the master branch with the canvas rewrite, so there's no need to update this code to work with the changes for tracking the active document)
@cameronwhite cameronwhite marked this pull request as ready for review July 6, 2025 15:49
@cameronwhite cameronwhite merged commit 9860750 into release-3.0 Jul 6, 2025
6 of 10 checks passed
@cameronwhite cameronwhite deleted the backport/3.0.2 branch July 6, 2025 15:50
@pedropaulosuzuki

Copy link
Copy Markdown
Contributor

@cameronwhite I forgot to suggest #1489 to be backported as well, my bad. Maybe for 3.0.3?

@cameronwhite

Copy link
Copy Markdown
Member Author

Sure, that seems reasonable to backport. I'll probably do a 3.0.3 as soon as the Mac icon bug can be figured out

@pedropaulosuzuki

Copy link
Copy Markdown
Contributor

Sure, that seems reasonable to backport. I'll probably do a 3.0.3 as soon as the Mac icon bug can be figured out

#1500 probably is also a good candidate for 3.0.3 btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants