Fixed a mistake in Atkinson dithering method#1489
Merged
Merged
Conversation
Contributor
Author
|
I was tired when I wrote the code on commit fe93db3, so I made a mistake and the test failed, but if the factor is changed to 0.125 it should succeed. Wheter we take all commits or discard the last one is a matter of whether we want a divider or a factor |
Member
|
Having it as a factor seems better to me, especially if |
Contributor
Author
|
Great @cameronwhite . It is a factor now, and I'm expressing the constant value in a way that makes the reasoning clearer :) |
4 tasks
cameronwhite
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Changed name of `TotalWeight` and made it a factor, not a divider (cherry picked from commit ef75386)
cameronwhite
pushed a commit
that referenced
this pull request
Aug 1, 2025
* Changed name of `TotalWeight` and made it a factor, not a divider (cherry picked from commit ef75386)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I first read the article (https://tannerhelland.com/2012/12/28/dithering-eleven-algorithms-source-code.html) from which I drew the implementation of the dithering effect (#457), I didn't notice that the Atkinson method involves a 'reduced color bleed'. That is, one does not divide by the sum of the elements of the matrix, but by something larger.