Only add a handler for the brush width's OnValueChanged event once#1460
Merged
Conversation
This was being done every time the tool was entered, which is incorrect and will cause the event handler to be run multiple times (after the fixes in gir.core for how closures are implemented). This also triggered a bug in gir.core from subscribing to the signal multiple times with the exact same delegate. Bug: #1340 Bug: #1340
Contributor
|
I'm confirming that Pinta crashed often when I tried to adjust the brush width. I didn't report it because I couldn't reproduce it reliably. It's great to see that it's being addressed. |
cameronwhite
added a commit
that referenced
this pull request
May 30, 2025
…1460) This was being done every time the tool was entered, which is incorrect and will cause the event handler to be run multiple times (after the fixes in gir.core for how closures are implemented). This also triggered a bug in gir.core from subscribing to the signal multiple times with the exact same delegate. Bug: #1340 (cherry picked from commit 8e1f542)
cameronwhite
added a commit
that referenced
this pull request
Jun 8, 2025
…1460) This was being done every time the tool was entered, which is incorrect and will cause the event handler to be run multiple times (after the fixes in gir.core for how closures are implemented). This also triggered a bug in gir.core from subscribing to the signal multiple times with the exact same delegate. Bug: #1340 (cherry picked from commit 8e1f542)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was being done every time the tool was entered, which is incorrect and will cause the event handler to be run multiple times (after the fixes in gir.core for how closures are implemented).
This also triggered a bug in gir.core from subscribing to the signal multiple times with the exact same delegate.
Bug: #1340