Add and use css styles#1391
Merged
Merged
Conversation
cameronwhite
left a comment
Member
There was a problem hiding this comment.
Looks good! Just had a couple suggestions in the comments
| -gtk-icon-size: 2rem; | ||
| } | ||
|
|
||
| .tool-box-scale { |
Member
There was a problem hiding this comment.
Nitpick on the naming - I'd call this tool-bar-scale since the "toolbox" is the left panel with the tools
|
|
||
|
|
||
| SetCssClasses (["ToolBoxButton", AdwaitaStyles.Flat]); | ||
| SetCssClasses (["tool-box-button", AdwaitaStyles.Flat]); |
Member
There was a problem hiding this comment.
It would be great to also add string constants for the style names, especially if any styles end up being used multiple times, e.g Styles.ToolBoxButton
Something similar to Pinta.Resources/Icons.cs would be a good place since the stylesheet is also embedded in that library
Contributor
Author
There was a problem hiding this comment.
Yes, I was thinking it will be good for consistency to have something similar to AdwaitaStyles, but I didn't know where to put it.
cameronwhite
pushed a commit
that referenced
this pull request
May 30, 2025
- Reduce the margin of slider widgets in the toolbar to avoid height changes when switching tools (cherry picked from commit 1a161ec)
cameronwhite
pushed a commit
that referenced
this pull request
Jun 8, 2025
- Reduce the margin of slider widgets in the toolbar to avoid height changes when switching tools (cherry picked from commit 1a161ec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1370