Support nested mapped parameters#166
Merged
sea-bass merged 8 commits intoPickNikRobotics:mainfrom Mar 8, 2024
Merged
Conversation
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
christophfroehlich
approved these changes
Mar 5, 2024
Collaborator
christophfroehlich
left a comment
There was a problem hiding this comment.
Hard to review the jinja temlates, but the code generated from the provided yaml looks good.
And I tested it with ros2_controllers, it doesn't break current configs.
Should one update the README describing this?
895887d to
7f7c2e5
Compare
7f7c2e5 to
b6633be
Compare
sea-bass
approved these changes
Mar 8, 2024
This was referenced Mar 18, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue #151 describes a problem when using multiple levels of nested maps. Currently, only one level of nesting is supported.