Added command byte count to SCSI command mapping#966
Merged
Conversation
|
SonarCloud Quality Gate failed. |
akuker
approved these changes
Nov 6, 2022
akuker
pushed a commit
that referenced
this pull request
Nov 10, 2022
* Extended mapping table with command byte count * Terminate early if command is unknown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also re-added a missing "exit" line in the TerminationHandler, which by accident I removed in the last PR.
There is one change related to the handling of unknown SCSI commands: These are not dispatched anymore (commands not contained in the command mapping can never be known by any device anyway), but the controller immediately reports an error. This improves the handling of unknown command opcodes: Previously for unknown commands a 6 byte command count was assumed, even though an unknown SCSI command can have any byte count. This change might improve the compatibility to clients which send commands (with a byte count > 6) rascsi does not support.