Removed wrong inheritance of SCDP and SCBR from Disk class#948
Merged
Removed wrong inheritance of SCDP and SCBR from Disk class#948
Conversation
Contributor
Author
|
I have to revert this PR to draft status because I may have found a bug. |
Contributor
Author
|
Resolving the issue I found resulted in also resolving issue #189. |
|
SonarCloud Quality Gate failed. |
akuker
reviewed
Oct 29, 2022
| return 16; | ||
| } else if (opcode == 0xA0) { | ||
| return 12; | ||
| } else if (opcode == 0x05 || (opcode >= 0x20 && opcode <= 0x7D)) { |
Contributor
Author
There was a problem hiding this comment.
@akuker I don't know, this is why I removed it. It might be something used in the past by the SASI controller.
akuker
approved these changes
Oct 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides repairing the broken inheritance (this fixes issues 189 and 663) I also fixed some TODOs.