Skip to content

Daynaport and Bridge shall not be a subclass of Disk #663

@uweseimet

Description

@uweseimet

In order to improve code quality and maintainability SCSIDaynaPort and SCSIBridge should not inherit from Disk, because they are no disk-like devices, not even mass storage devices. The correct base class is PrimaryDevice. Inhertiing from Disk is not just wrong from an object-oriented perspective, it also forces disk-specific geometry mode pages onto the Daynaport and Bridge device and probably more.

Metadata

Metadata

Assignees

Labels

architectureSoftware architecture and code quality

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions