-
-
Notifications
You must be signed in to change notification settings - Fork 89
Daynaport and Bridge shall not be a subclass of Disk #663
Copy link
Copy link
Closed
Labels
architectureSoftware architecture and code qualitySoftware architecture and code quality
Description
In order to improve code quality and maintainability SCSIDaynaPort and SCSIBridge should not inherit from Disk, because they are no disk-like devices, not even mass storage devices. The correct base class is PrimaryDevice. Inhertiing from Disk is not just wrong from an object-oriented perspective, it also forces disk-specific geometry mode pages onto the Daynaport and Bridge device and probably more.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
architectureSoftware architecture and code qualitySoftware architecture and code quality