Address Sonarcloud issues for the html code; improve on css styles#892
Address Sonarcloud issues for the html code; improve on css styles#892
Conversation
…ility with old browsers.
…atives where needed
|
@uweseimet FYI, I'm addressing issues reported by SonarCloud for the html code here. I've also tweaked the rules so that we may see more structural and semantic issues raised in the next report. |
|
@rdmark Regarding SonarCloud, any news on making the develop branch a long-living branch? |
|
@rdmark There are more HTML issues reported now, indeed. I would also like to make the C++ rules stricter. Can you please enable these currently inactive rules?
Depending on the result I might have to asked you to disable some of these rules again. Sometimes it's hard to assess the effect of additional rules unless you see it. |
|
I don't agree with the "GNU extensions should not be used" rule. When are we going to use a non-GNU compiler? I'm OK with trying these to see what happens. But, I'd like to move past the huge PRs that don't fix functional issues or add features. Around October 15th or so, I'd like to lock down the code base to only bug fixes so we can shoot for a stable release at the end of the month. |
|
@akuker Sounds fine for me. Regarding the GNU extension settings I don't consider it important. i was just curious whether there is actually anything GNU specific being used. |
nucleogenic
left a comment
There was a problem hiding this comment.
I've given this a first pass. It's definitely looking a lot cleaner already.
A sprinkling of somewhat nitpicky comments.
I've done some basic testing in Netscape 4.08, Classilla, iCab, etc and didn't notice any major issues.
nucleogenic
left a comment
There was a problem hiding this comment.
Can you check drive creation from the named drives page? Getting an error here.
|
SonarCloud Quality Gate failed. |
) Refactor and clean up code to conform to SonarCloud static analysis, improve readability and semantics. - Add labels for each form input, and tweak placeholder text accordingly. - Move CSS styles to the stylesheet; minor tweaks for clarity and consistency - Use the legacy align=center attribute for centering paragraphs (backwards compatible) - Remove all instances of using tables for layout - Add header tags to all remaining tables, with scope parameters. - Add descriptions to each table - Move drive reference hyperlinks to the drive name column (addresses "same link text leads to different URL" code smell.) - Inject lang parameters to each html tag - Standardize on h2 tags as top header for each template - Add 'json' to config file UI elements, to communicate actual file name/format - Clean up indentation - Dropbox styling: Added a colored outline, added padding to more clearly communicate its function. Hid the (X) SVG that indicates failure, since failure is already communicated by the error text. Also, the SVG always obstructed the file name or error so was quite counter-productive.
Uh oh!
There was an error while loading. Please reload this page.