Conversation
|
Note: there are other changes/improvements needed. This is just the initial PR to break things up. More changes will be coming |
|
@akuker Not sure what you mean with -Wextra. Currently it is part of the build process (this is why I found the compile-time issue on buster today), and it should stay in the Makefile, because our code compiles fine with it. |
uweseimet
left a comment
There was a problem hiding this comment.
Approved, from my side. Please check my comment on -Wextra, please.
I added this back in. Thanks @uweseimet ! |
|
0cb6948 and 42178fb are identical now. @uweseimet - would you mind taking a look at this again and make sure I didn't mess something up? I accidentally checked in a bunch of banana pi changes before I merged this PR :( |
|
SonarCloud Quality Gate failed.
|
|
@akuker I could not find anything obviously wrong. I don't think that anything bad can happen anyway, because essentially that is a code move and not a change, and I bet that if something was wrong, rascsi would not work at al anymorel, i.e. there is hardly any potential of missing anything hidden. |
|
Thanks @uweseimet |
This is intended to separate the systimer class from gpiobus and to move the different board types to their own header files. There shouldn't be any functional changes.
I removed the -Wextra from the Makefile since it looks like we lost that change. Let me know if you think it needs to stay in there.