In case all IDs are reserved recommend 0#768
Merged
rdmark merged 23 commits intoPiSCSI:developfrom Jul 1, 2022
Merged
Conversation
…ce the correct gender of parts. Should be no functional change
…ce the correct gender of parts. Should be no functional change
* Update README.md Added reference to gitflow * Updated to match new versioning structure (PiSCSI#73) * Updated to match new versioning structure * fix version number Co-authored-by: Tony Kuker <akuker@gmail.com> * Scsimon improvements (PiSCSI#74) * Updated scsimon to save data on a nano-second time scale, instead of micro-second * Cleanup error messages and data types Co-authored-by: Tony Kuker <akuker@gmail.com> * Updated for new version number * Change reported version back to development build Co-authored-by: Tony Kuker <akuker@gmail.com>
Merge 21.05.1 changes to master
* First attempt at adding 2.5 inch drive connector * Clean up silkscreen and fix DRC issues * additional cleanup. Made Pin 1 of the PB connector square * minor tweaks * Updates for ordered version * Generate step file and schematic pdf * First draft of powerbook drive bracket * Added side holes and hole for MIPI connector * Additional updates to the powerbook 3d printed bracket * Moved RaSCSI board 1mm in + lots of cleanup * Added optional floppy power connector. As-ordered version 2.4a * Added optional floppy power connector. As-ordered version 2.4a Co-authored-by: Tony <akuker@gmail.com>
Bumps [pillow](https://github.com/python-pillow/Pillow) from 8.1.2 to 8.2.0. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/master/CHANGES.rst) - [Commits](python-pillow/Pillow@8.1.2...8.2.0) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
added link to compatibility list.
This reverts commit 9021466.
October 2021 Release
RaSCSI version 21.11.1
RaSCSI version 21.12.01
RaSCSI version 22.02.01
RaSCSI version 22.05.02
Otherwise the occupied list is empty and this exception brings down the whole web interface. This can be easily provoked by just reserving all IDs in the web interface.
Member
|
@philenotfound Thanks for taking the time to submit a patch! Now, are you sure you tested this against the master branch code? I can honestly not reproduce the reported issue. |
rdmark
requested changes
Jul 1, 2022
Member
rdmark
left a comment
There was a problem hiding this comment.
Cannot reproduce issue that this code supposedly fixes.
Contributor
Author
|
Reproduced with 348b5dd.
To recover you have to restart rascsi-web.service |
Member
|
Now I get it, thanks. Somehow I read it as attaching to all ids. It is quite the corner case. Good catch! |
rdmark
approved these changes
Jul 1, 2022
Member
|
One request for future contributions: Please prepare PRs against the develop branch. We never work directly in the master branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise the occupied list is empty and this exception brings down the
whole web interface.
This can be easily provoked by just reserving all IDs in the web interface.