Skip to content

Added support for new interfaces syntax#684

Merged
uweseimet merged 50 commits intodevelopfrom
feature_updated_interface_syntax
Feb 20, 2022
Merged

Added support for new interfaces syntax#684
uweseimet merged 50 commits intodevelopfrom
feature_updated_interface_syntax

Conversation

@uweseimet
Copy link
Copy Markdown
Contributor

@uweseimet uweseimet commented Feb 19, 2022 •
edited
Loading

@rdmark Can you please test?

  SCBR  Supported LUN numbers: 0-31
        Parameter support
        Default parameters: inet=10.10.20.1/24
                            interface=eth0
  SCDP  Supported LUN numbers: 0-31
        Parameter support
        Default parameters: inet=10.10.20.1/24
                            interface=eth0

>rascsi -ID6 -t scdp "interface=eth1:inet=1.1.1.1/24

  6:0  SCDP  Dayna:SCSI/Link:1.4a  inet=1.1.1.1/24:interface=eth1

@uweseimet uweseimet requested a review from rdmark February 19, 2022 08:51
@uweseimet uweseimet linked an issue Feb 19, 2022 that may be closed by this pull request
Update parameter handling for network interface #682
Closed
@uweseimet uweseimet marked this pull request as draft February 19, 2022 08:54
@uweseimet
Copy link
Copy Markdown
Contributor Author

uweseimet commented Feb 19, 2022 •
edited
Loading

@rdmark I just noticed that the netmask is currently part of the IP address (IP/NETMASK). I think we should keep it that way, it is a legal notation. Note that the new syntax uses "interface" instead of "interfaces", in make backwards compatiblity easier. All in all one could claim "interface" is better anyway, because only one interface from the list is going to be used anyway :).

@rdmark
Copy link
Copy Markdown
Member

rdmark commented Feb 19, 2022

@uweseimet I'm good with keeping inet and mask together in one parameter. Been testing the latest code for a bit and it seems to work as expected. Here's how the Web UI interprets the new default parameters for network devices.

Screenshot 2022-02-19 at 14-50-19 RaSCSI Control Page

@rdmark rdmark mentioned this pull request Feb 20, 2022
Merged
@uweseimet
Copy link
Copy Markdown
Contributor Author

uweseimet commented Feb 20, 2022

@rdmark Looks good. Only having 2 parameters has the advantage of needing less space on the screen. For the web ui this is not that relevant, but for a smartphone it makes a difference.
But it may just be a matter of time until we will have more than 2 parameters (elsewhere) ;-).

@uweseimet uweseimet marked this pull request as ready for review February 20, 2022 08:28
rdmark
rdmark approved these changes Feb 20, 2022
View reviewed changes
doc/rascsi.1 Outdated
n is the SCSI ID number (0-7). u (0-31) is the optional LUN (logical unit). The default LUN is 0.
.IP
FILE is the name of the image file to use for the SCSI device. For devices that do not support an image file (SCBR, SCDP, SCLP, SCHS) the filename may have a special meaning or a dummy name can be provided. For SCBR and SCDP it is an optioinal prioritized list of network interfaces, e.g. "interfaces=eth0,eth1,wlan0". For SCLP it is the print command to be used and a reservation timeout in seconds, e.g. "cmd=lp -oraw:timeout=60".
FILE is the name of the image file to use for the SCSI device. For devices that do not support an image file (SCBR, SCDP, SCLP, SCHS) the filename may have a special meaning or a dummy name can be provided. For SCBR and SCDP it is an optioinal prioritized list of network interfaces, an optional IP address and netmask, e.g. "interfaces=eth0,eth1,wlan0:inet=10.10.20.1/24". For SCLP it is the print command to be used and a reservation timeout in seconds, e.g. "cmd=lp -oraw:timeout=60".
Copy link
Copy Markdown
Member

@rdmark rdmark Feb 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add '%f' to the printer cmd parameter example, since it is mandatory?

doc/rascsi_man_page.txt Outdated
tized list of network interfaces, an optional IP address and
netmask, e.g. "interfaces=eth0,eth1,wlan0:inet=10.10.20.1/24".
For SCLP it is the print command to be used and a reservation
timeout in seconds, e.g. "cmd=lp -oraw:timeout=60".
Copy link
Copy Markdown
Member

@rdmark rdmark Feb 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the above.

Copy link
Copy Markdown
Contributor Author

@uweseimet uweseimet Feb 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. rascsi_man_page.txt is generated from rascsi.1.

@uweseimet uweseimet merged commit 2beb787 into develop Feb 20, 2022
@uweseimet uweseimet deleted the feature_updated_interface_syntax branch February 20, 2022 17:40
@uweseimet uweseimet mentioned this pull request Nov 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdmark rdmark rdmark approved these changes

@akuker akuker Awaiting requested review from akuker akuker is a code owner

@erichelgeson erichelgeson Awaiting requested review from erichelgeson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update parameter handling for network interface

2 participants

@uweseimet @rdmark