Skip to content

Improve performance when reading sectors#1344

Merged
uweseimet merged 1 commit intodevelopfrom
issue_1343_1
Nov 15, 2023
Merged

Improve performance when reading sectors#1344
uweseimet merged 1 commit intodevelopfrom
issue_1343_1

Conversation

@uweseimet
Copy link
Copy Markdown
Contributor

@uweseimet uweseimet commented Nov 12, 2023 •
edited
Loading

This addresses item 1. in #1343.

@uweseimet uweseimet marked this pull request as ready for review November 12, 2023 14:32
@uweseimet uweseimet linked an issue Nov 12, 2023 that may be closed by this pull request
Improve performance when reading sectors #1343
Closed
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@uweseimet
Copy link
Copy Markdown
Contributor Author

uweseimet commented Nov 12, 2023 •
edited
Loading

Just thought that I should also test this on a Pi Zero, not just on a Pi 4. On the Zero optimization 2. in #1343 may (also) be interesting, even though it is not useful for the Pi 4. Making this PR a draft until I have results on a Pi Zero.

@uweseimet uweseimet marked this pull request as draft November 12, 2023 15:03
@uweseimet
Copy link
Copy Markdown
Contributor Author

uweseimet commented Nov 12, 2023 •
edited
Loading

On the Pi Zero there is also a slight improvement, and it definitely id not slower.

@uweseimet uweseimet marked this pull request as ready for review November 12, 2023 18:59
rdmark
rdmark approved these changes Nov 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdmark rdmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So about 1% increased read throughput on either RPi model ?

@uweseimet
Copy link
Copy Markdown
Contributor Author

uweseimet commented Nov 15, 2023

So about 1% increased read throughput on either RPi model ?

On the Pi Zero you do not really see a difference. On the Pi 4 it is about 1%. Not much, but anyway: More speed because of less code ;-).

@uweseimet uweseimet merged commit ec9f83f into develop Nov 15, 2023
@uweseimet uweseimet deleted the issue_1343_1 branch November 15, 2023 06:44
uweseimet added a commit that referenced this pull request Nov 15, 2023
@uweseimet
Improve performance when reading sectors (#1344)
535f62f
uweseimet added a commit that referenced this pull request Nov 15, 2023
@uweseimet
Improve performance when reading sectors (#1344)
3348b9a
uweseimet added a commit that referenced this pull request Nov 15, 2023
@uweseimet
Improve performance when reading sectors (#1344)
665e78a
uweseimet added a commit that referenced this pull request Nov 16, 2023
@uweseimet
Improve performance when reading sectors (#1344)
4ea5f02
rdmark pushed a commit that referenced this pull request May 1, 2024
@uweseimet @rdmark
Improve performance when reading sectors (#1344)
d1166ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdmark rdmark rdmark approved these changes

@akuker akuker Awaiting requested review from akuker akuker is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve performance when reading sectors

2 participants

@uweseimet @rdmark