Use standard C++ timer for long timeouts (#1327), remove unused code#1328
Use standard C++ timer for long timeouts (#1327), remove unused code#1328
Conversation
|
SonarCloud Quality Gate failed.
|
rdmark
left a comment
There was a problem hiding this comment.
Was it Sonar that made you aware of the bitrotted code?
| enum class mode_e { | ||
| TARGET = 0, | ||
| INITIATOR = 1, | ||
| MONITOR = 2, |
There was a problem hiding this comment.
No, it is not. Otherwise it would already break when compiling. You know how much I like to repeat that there is a lot of unused code ;-).
No, I stumble upon this when reviewing and cleaning up the existing code. Only recently I also started with that for the code in hal. Often, as soon as you remove an unused method, for instance, another unused method or field pops up, which before was only used by the unused code you have just removed. And so on ... |
Have you tried using |
I have never heard of cppcheck. Sounds like it is something I should try. |
…1328) * Replace timer in WaitSignal() ' Remove unused code * Remove unused file
…1328) * Replace timer in WaitSignal() ' Remove unused code * Remove unused file
…1328) * Replace timer in WaitSignal() ' Remove unused code * Remove unused file
Just tried gcccheck. It takes less than 4 seconds on my PC. And indeed it found unused code and redundant assignments and a redundant condition. Not that many code locations, but SonarCloud did not find them. |
…1328) * Replace timer in WaitSignal() ' Remove unused code * Remove unused file
No description provided.