@rdmark I have a question related to expectation management ;-). There are currently 7 draft PRs targeting the release after the upcoming bookworm release. Except for #1323 there are only minimal changes, #1323 has the most changes, but it's essentially just moving code between classes.
Any idea when you might be able to review these tickets? There is currently a lot of testing going on. Regarding the daynaport I can now run most tests also on my hardware, and @benjamink is providing excellent help with testing on the Mac, not just related to the daynaport, but also other things. #1295 will provide us more means of partially automated testing. It contains a lot of code changes, though, but I have tried to extract some key changes into the existing small separate PRs.
All in all, I would not want to lose momentum. Merging all these changes into develop swiftly after the upcoming release would be very useful.

@uweseimet Regarding expectations, I’m on a business trip the whole week without a personal computer. I’m doing this code review on my iPhone right now.

Please be understanding with this being a hobby that we (most of us?) do for fun at our spare time. I enjoy reviewing your code but have limited spare time during the weeks…

At the same time I understand your eagerness to make progress with your refactoring and code quality improvements. Please bear with me as I work through these PRs.

@rdmark Sure, no problem. Note that the remaining ones are small, the device factory one was the biggest by far. When these are merged I will need time to merge the changes back into my current tickets anyway. What I mean to say is, that I do not expect that many PRs by me any time soon ;-).

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information