Skip to content

Fix assertion when creating a removable media drive with an empty filename#1308

Merged
uweseimet merged 1 commit intodevelopfrom
issue_1307
Nov 5, 2023
Merged

Fix assertion when creating a removable media drive with an empty filename#1308
uweseimet merged 1 commit intodevelopfrom
issue_1307

Conversation

@uweseimet
Copy link
Copy Markdown
Contributor

@uweseimet uweseimet commented Nov 4, 2023

Must have been a very old bug. Fixed:

>piscsi -id 0 -t SCRM ""
+----+-----+------+-------------------------------------
| ID | LUN | TYPE | IMAGE FILE
+----+-----+------+-------------------------------------
|  0 |   0 | SCRM | NO MEDIUM
+----+-----+------+-------------------------------------

@uweseimet uweseimet linked an issue Nov 4, 2023 that may be closed by this pull request
Assertion when creating a removable media drive with an empty filename #1307
Closed
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@uweseimet uweseimet marked this pull request as ready for review November 4, 2023 14:45
@uweseimet uweseimet marked this pull request as draft November 4, 2023 14:46
@uweseimet uweseimet marked this pull request as ready for review November 4, 2023 14:47
@uweseimet uweseimet changed the title Fix assertion when creating a removable media drive without filename Fix assertion when creating a removable media drive with an empty filename Nov 4, 2023
rdmark
rdmark approved these changes Nov 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdmark rdmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you add a unit test for this scenario already?

@uweseimet
Copy link
Copy Markdown
Contributor Author

uweseimet commented Nov 5, 2023 •
edited
Loading

@rdmark No, amything that has to do with the command line is hard or impossible to unit test, but #1295 might help with that. Instead of running scsidump against piscsi you could programmatically run scsictl against piscsi. Then you can send any scsictl command and any SCSI command to piscsi in-process and verify the results. This would test both piscsi and scsictl at the same time.

@uweseimet uweseimet merged commit 39dd1d3 into develop Nov 5, 2023
@uweseimet uweseimet deleted the issue_1307 branch November 5, 2023 09:11
uweseimet added a commit that referenced this pull request Nov 5, 2023
@uweseimet
Fix assertion when creating a removable media drive without filename (#…
6c727ef 
…1308)
uweseimet added a commit that referenced this pull request Nov 5, 2023
@uweseimet
Fix assertion when creating a removable media drive without filename (#…
0e8feab 
…1308)
uweseimet added a commit that referenced this pull request Nov 5, 2023
@uweseimet
Fix assertion when creating a removable media drive without filename (#…
2d1a10d 
…1308)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdmark rdmark rdmark approved these changes

@akuker akuker Awaiting requested review from akuker akuker is a code owner

@erichelgeson erichelgeson Awaiting requested review from erichelgeson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assertion when creating a removable media drive with an empty filename

2 participants

@uweseimet @rdmark