Skip to content

Only build scsidump when building for the FULLSPEC board (#1285)#1286

Merged
uweseimet merged 6 commits intodevelopfrom
issue_1285
Nov 7, 2023
Merged

Only build scsidump when building for the FULLSPEC board (#1285)#1286
uweseimet merged 6 commits intodevelopfrom
issue_1285

Conversation

@uweseimet
Copy link
Copy Markdown
Contributor

@uweseimet uweseimet commented Nov 2, 2023

@rdmark It may be considered to merge this change into the upcoming release. It's easy to test and has no side effects.

@uweseimet uweseimet marked this pull request as draft November 2, 2023 15:00
@uweseimet uweseimet linked an issue Nov 2, 2023 that may be closed by this pull request
Only build scsidump when building for the FULLSPEC board #1285
Closed
@erichelgeson erichelgeson removed their request for review November 4, 2023 21:28
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@uweseimet
Copy link
Copy Markdown
Contributor Author

uweseimet commented Nov 5, 2023

@rdmark While we are waiting for progress on the daynaport ticket we migiht consider merging this one. Would you agree?

@rdmark
Copy link
Copy Markdown
Member

rdmark commented Nov 5, 2023 via email

@uweseimet uweseimet marked this pull request as ready for review November 5, 2023 12:23
@uweseimet uweseimet mentioned this pull request Nov 7, 2023
Closed
@uweseimet uweseimet merged commit 616e11e into develop Nov 7, 2023
@uweseimet uweseimet deleted the issue_1285 branch November 7, 2023 23:26
uweseimet added a commit that referenced this pull request Nov 8, 2023
@uweseimet
Only build scsidump when building for the FULLSPEC board (#1285) (#1286
3856273 
)

* Only build scsidump when building for the FULLSPEC board

* Only install scsidump manpage when building for the FULLSPEC board

* Only install scsidump binary when building for the FULLSPEC board

* Revert debug optimization back to -O0, -Og omits some information
uweseimet added a commit that referenced this pull request Nov 8, 2023
@uweseimet
Only build scsidump when building for the FULLSPEC board (#1285) (#1286
58660d8 
)

* Only build scsidump when building for the FULLSPEC board

* Only install scsidump manpage when building for the FULLSPEC board

* Only install scsidump binary when building for the FULLSPEC board

* Revert debug optimization back to -O0, -Og omits some information
uweseimet added a commit that referenced this pull request Nov 8, 2023
@uweseimet
Only build scsidump when building for the FULLSPEC board (#1285) (#1286
d3ee8b6 
)

* Only build scsidump when building for the FULLSPEC board

* Only install scsidump manpage when building for the FULLSPEC board

* Only install scsidump binary when building for the FULLSPEC board

* Revert debug optimization back to -O0, -Og omits some information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdmark rdmark rdmark approved these changes

@akuker akuker Awaiting requested review from akuker akuker is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Only build scsidump when building for the FULLSPEC board

2 participants

@uweseimet @rdmark