Skip to content

Fix MESSAGE OUT handling for initiator mode (#1283)#1284

Merged
uweseimet merged 3 commits intodevelopfrom
issue_1283
Nov 8, 2023
Merged

Fix MESSAGE OUT handling for initiator mode (#1283)#1284
uweseimet merged 3 commits intodevelopfrom
issue_1283

Conversation

@uweseimet
Copy link
Copy Markdown
Contributor

@uweseimet uweseimet commented Nov 1, 2023 •
edited
Loading

This PR can wait until right after the first bookworm release, because in this release MESSAGE OUT in initiator mode is not yet used.
It is going to be needed by the upcoming improved scsidump.

@uweseimet uweseimet requested a review from dialtr November 1, 2023 20:44
@uweseimet uweseimet linked an issue Nov 1, 2023 that may be closed by this pull request
Initiator mode: Handshake does not work for MESSAGE OUT phase #1283
Closed
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@uweseimet uweseimet mentioned this pull request Nov 7, 2023
Merged
@uweseimet
Copy link
Copy Markdown
Contributor Author

uweseimet commented Nov 8, 2023

@rdmark Even though we do not need this change for the bookworm release I would like to merge it. It would make my life a bit easier, because currently I have to keep track of several pending PRs and issue changes.
In case you agree I will request a review on this draft.

@rdmark
Copy link
Copy Markdown
Member

rdmark commented Nov 8, 2023

@uweseimet So you're saying that this function isn't used by any application currently? If you think the change is safe I don't have any objection.

@uweseimet
Copy link
Copy Markdown
Contributor Author

uweseimet commented Nov 8, 2023 •
edited
Loading

@rdmark Yes, it is not yet used anywhere. The only application running in initiator mode is scsidump, but only the upcoming scsidump version (for the release after the first bookworm release) makes use of it. When testing this upcoming version I noticed the bug, which has always been there.

@uweseimet uweseimet marked this pull request as ready for review November 8, 2023 09:26
@uweseimet uweseimet merged commit 0ab2f20 into develop Nov 8, 2023
@uweseimet uweseimet deleted the issue_1283 branch November 8, 2023 10:25
uweseimet added a commit that referenced this pull request Nov 8, 2023
@uweseimet
Fix MESSAGE OUT handling for initiator mode (#1283) (#1284)
5e62852
uweseimet added a commit that referenced this pull request Nov 8, 2023
@uweseimet
Fix MESSAGE OUT handling for initiator mode (#1283) (#1284)
55b0e6e
uweseimet added a commit that referenced this pull request Nov 8, 2023
@uweseimet
Fix MESSAGE OUT handling for initiator mode (#1283) (#1284)
36806dd 
* Fix MESSAGE OUT handling

* Update logging

* Add assertion
uweseimet added a commit that referenced this pull request Nov 8, 2023
@uweseimet
Fix MESSAGE OUT handling for initiator mode (#1283) (#1284)
78cf4a9 
* Fix MESSAGE OUT handling

* Update logging

* Add assertion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdmark rdmark rdmark approved these changes

@dialtr dialtr Awaiting requested review from dialtr

@akuker akuker Awaiting requested review from akuker akuker is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Initiator mode: Handshake does not work for MESSAGE OUT phase

2 participants

@uweseimet @rdmark