Skip to content

Remove unused duplicate code dealing with MODE SELECT (#1268)#1269

Merged
uweseimet merged 2 commits intodevelopfrom
issue_1268
Oct 29, 2023
Merged

Remove unused duplicate code dealing with MODE SELECT (#1268)#1269
uweseimet merged 2 commits intodevelopfrom
issue_1268

Conversation

@uweseimet
Copy link
Copy Markdown
Contributor

@uweseimet uweseimet commented Oct 25, 2023

Test results:

[2023-10-25 19:29:11.246] [debug] (ID 5) - Controller is executing ModeSelect6, CDB $151100001c00
[2023-10-25 19:29:11.246] [debug] (ID:LUN 5:0) - Device is executing ModeSelect6 ($15)
[2023-10-25 19:29:11.246] [warning] In order to change the sector size use the -b option when launching piscsi
[2023-10-25 19:29:11.246] [debug] (ID 5) - Error status: Sense Key $5, ASC $26

After the code removal MODE SELECT is still working as expected.

@uweseimet uweseimet linked an issue Oct 25, 2023 that may be closed by this pull request
Remove unused duplicate code dealing with MODE SELECT #1268
Closed
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@uweseimet uweseimet marked this pull request as ready for review October 25, 2023 18:32
@uweseimet uweseimet requested a review from dialtr October 25, 2023 18:32
@uweseimet uweseimet merged commit d6116bf into develop Oct 29, 2023
@uweseimet uweseimet deleted the issue_1268 branch October 29, 2023 12:01
uweseimet added a commit that referenced this pull request Oct 30, 2023
@uweseimet
Remove unused duplicate code dealing with MODE SELECT (#1268) (#1269)
12998c8 
* Remove unused code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdmark rdmark rdmark approved these changes

@akuker akuker Awaiting requested review from akuker akuker is a code owner

@erichelgeson erichelgeson Awaiting requested review from erichelgeson

@dialtr dialtr Awaiting requested review from dialtr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unused duplicate code dealing with MODE SELECT

2 participants

@uweseimet @rdmark