Conversation
|
SonarCloud Quality Gate failed.
|
Contributor
Author
|
This PR is blocking further PRs, e.g. for tickets like #1092, because these tickets require this PR to be merged first in order to save me from a code conflict hell. |
dialtr
approved these changes
Oct 22, 2023
Collaborator
dialtr
left a comment
There was a problem hiding this comment.
LGTM. I also grepped the source for any references to allwinner/banana that may have been missed and found none.
Contributor
Author
uweseimet
added a commit
that referenced
this pull request
Oct 22, 2023
* Remove non-working Banana Pi code * Remove SonarQube suppressions which can be resolved by a code update * Update device detection
uweseimet
added a commit
that referenced
this pull request
Oct 22, 2023
* Remove non-working Banana Pi code * Remove SonarQube suppressions which can be resolved by a code update * Update device detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successfully tested with a Pi 4.