Skip to content

Do not write data when executing VERIFY10/VERIFY16 (#807)#1250

Merged
uweseimet merged 1 commit intodevelopfrom
issue_807
Oct 22, 2023
Merged

Do not write data when executing VERIFY10/VERIFY16 (#807)#1250
uweseimet merged 1 commit intodevelopfrom
issue_807

Conversation

@uweseimet
Copy link
Copy Markdown
Contributor

@uweseimet uweseimet commented Oct 16, 2023 •
edited
Loading

Successfully tested with an Atari TT:

[2023-10-16 20:46:09.026] [debug] (ID 1) - Controller is executing Write6/Print/SendMessage10, CDB $0a03ebf60400
[2023-10-16 20:46:09.026] [debug] (ID:LUN 1:0) - Device is executing Write6/Print/SendMessage10 ($0a)
[2023-10-16 20:46:09.032] [debug] (ID 1) - Controller is executing Verify10, CDB $2f020003ebf600000400
[2023-10-16 20:46:09.032] [debug] (ID:LUN 1:0) - Device is executing Verify10 ($2f)

@uweseimet uweseimet linked an issue Oct 16, 2023 that may be closed by this pull request
SCSI VERIFY commands do not verify but write #807
Closed
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@uweseimet uweseimet marked this pull request as ready for review October 16, 2023 19:13
@uweseimet uweseimet requested a review from dialtr October 16, 2023 19:13
rdmark
rdmark approved these changes Oct 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdmark rdmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable enough change.

As mentioned in the ticket, my only question is what was was purpose the original VERIFY behavior was implemented for.

@uweseimet uweseimet merged commit 02d18b3 into develop Oct 22, 2023
@uweseimet uweseimet deleted the issue_807 branch October 22, 2023 14:20
uweseimet added a commit that referenced this pull request Oct 22, 2023
@uweseimet
Do not write data when executing VERIFY10/VERIFY16 (#1250)
6ac19f0
uweseimet added a commit that referenced this pull request Oct 22, 2023
@uweseimet
Do not write data when executing VERIFY10/VERIFY16 (#1250)
0cbe0f0
uweseimet added a commit that referenced this pull request Oct 22, 2023
@uweseimet
Do not write data when executing VERIFY10/VERIFY16 (#1250)
e307e27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdmark rdmark rdmark approved these changes

@akuker akuker Awaiting requested review from akuker akuker is a code owner

@erichelgeson erichelgeson Awaiting requested review from erichelgeson

@dialtr dialtr Awaiting requested review from dialtr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SCSI VERIFY commands do not verify but write

2 participants

@uweseimet @rdmark