Skip to content

Bump stylelint to 15.10.2 and remove deprecated module#1189

Merged
rdmark merged 6 commits intodevelopfrom
rdmark-stylelint15
Jul 29, 2023
Merged

Bump stylelint to 15.10.2 and remove deprecated module#1189
rdmark merged 6 commits intodevelopfrom
rdmark-stylelint15

Conversation

@rdmark
Copy link
Copy Markdown
Member

@rdmark rdmark commented Jul 20, 2023 •
edited
Loading

  • Bump stylelint and stylelint-config-standard libs to the latest versions (security fixes)
  • Remove deprecated stylelint-config-prettier module
  • Scan the classic style sheet with stylelint and prettier in the github workflow
  • Address stylelint and prettier issues in the classic stylesheet
  • Bump prettier to 3.0.0 (for good measure) -- this introduces a dependency with nodejs 14.x

@rdmark rdmark requested review from akuker, erichelgeson and nucleogenic and removed request for akuker and erichelgeson July 20, 2023 05:16
@rdmark rdmark mentioned this pull request Jul 20, 2023
Closed
@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Jul 21, 2023

@nucleogenic I bumped the prettier version to 3.0.0 after reading the changelog. They've done a ton of future proofing in this major version which seemed good to get ahead on. BUT, I realized afterwards that it introduces a dependency on nodejs 14, while Debian Bullseye only comes with v12. (Bookworm has v18!) The Ubuntu runners we're using seems to be using a recent enough version of nodejs so perhaps this is not a big deal? Thoughts?

nucleogenic
nucleogenic approved these changes Jul 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@nucleogenic nucleogenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update 👍

See comment about CSS range syntax in Safari < 16.4. I am approving anyway, because I don't think it's a good idea that we block progress on the modern theme for older browsers, but on the other hand, there doesn't appear to be a benefit to us using the range syntax at the moment.

@rdmark rdmark merged commit d3317e9 into develop Jul 29, 2023
@rdmark rdmark deleted the rdmark-stylelint15 branch July 29, 2023 05:53
rdmark added a commit that referenced this pull request Sep 24, 2023
@rdmark
Bump stylelint to 15.10.2 and remove deprecated module (#1189)
cecd86c 
- Bump stylelint and stylelint-config-standard libs to the latest versions (security fixes)
- Remove deprecated stylelint-config-prettier module
- Scan the classic style sheet with stylelint and prettier in the github workflow
- Address stylelint and prettier issues in the classic stylesheet
- Bump prettier to 3.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nucleogenic nucleogenic nucleogenic approved these changes

@erichelgeson erichelgeson Awaiting requested review from erichelgeson

@akuker akuker Awaiting requested review from akuker akuker is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rdmark @nucleogenic