Improve invalid path error handling, and escape single quotes in javascript#1174
Merged
Improve invalid path error handling, and escape single quotes in javascript#1174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I attempted using jinja2's built in escape filters, notable
escapeandtojson, but neither did what I needed with the single quotes. The current solution using thereplacefilter is a bit crude, but I needed to double escape the single quote to make the browser not interpret it "too early" to not break the javascript syntax. I think a better solution is to refactor the onsubmit event handler and put it in a script block rather than inline in the html element. I couldn't immediately think of how to do that for this dynamic table however.