Always assign locale in detect_locale()#1163
Merged
Conversation
Member
Author
|
I don't understand why the CI job is failing. Tried running with debug logging but it did not give any insights that I could spot. |
Member
Author
|
I ran the web ui integration tests locally and they passed |
Member
Author
|
To capture a Discord discussion: It was failing because Flask 2.3.x removed support for Python 3.7. Bumping the container to Bullseye gets us Python 3.9. |
gymdesk-nr
approved these changes
May 2, 2023
nucleogenic
approved these changes
May 16, 2023
rdmark
added a commit
that referenced
this pull request
Sep 24, 2023
* Always assign locale in detect_locale() * Bump version of Debian used in CI builds from from buster to bullseye * Update code comment --------- Co-authored-by: nucleogenic <nr@nucleogenic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out there are scenarios when session["language"] is set but not assigned to the respective piscsi_cmd and file_cmd object members.
This change always executes said assignment in detect_locale().