Skip to content

Remove use of deprecated before_first_request decorator#1162

Merged
rdmark merged 1 commit intodevelopfrom
rdmark-issue-1161
May 2, 2023
Merged

Remove use of deprecated before_first_request decorator#1162
rdmark merged 1 commit intodevelopfrom
rdmark-issue-1161

Conversation

@rdmark
Copy link
Copy Markdown
Member

@rdmark rdmark commented May 2, 2023

This runs the detect_locale() check for each request, but adds a check if session["language"] has already been set.

@rdmark rdmark requested review from akuker and erichelgeson as code owners May 2, 2023 01:22
@rdmark rdmark requested a review from nucleogenic May 2, 2023 01:23
@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented May 2, 2023

@nucleogenic This adds slightly to the overhead for each request. Can you think of a more elegant solution?

Copy link
Copy Markdown
Member

@nucleogenic nucleogenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me 👍

@rdmark rdmark merged commit 09d0598 into develop May 2, 2023
@rdmark rdmark deleted the rdmark-issue-1161 branch May 2, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants