Do not abort but only warn on unexpected CD-ROM image size#1084
Merged
Do not abort but only warn on unexpected CD-ROM image size#1084
Conversation
rdmark
reviewed
Jan 28, 2023
cpp/devices/scsicd.cpp
Outdated
| if (rawfile) { | ||
| if (size % 2536) { | ||
| throw io_exception("Raw ISO CD-ROM file size must be a multiple of 2536 bytes but is " | ||
| GetLogger().Warn("Raw ISO CD-ROM file size ist not a multiple of 2536 bytes but is " |
Contributor
Author
There was a problem hiding this comment.
Fixed, thank you for noticing this.
rdmark
approved these changes
Jan 28, 2023
rdmark
pushed a commit
that referenced
this pull request
Jan 28, 2023
* Do not abort but only warn on unexpected CD-ROM image size * Unit test update * Updated exception handling * Cleanup * Fixed typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed some redundant comments.