chore: backport general fixes from #42 to main (collegemap workspace + migration gotchas)#47
Merged
Merged
Conversation
The root pnpm-workspace.yaml owns all workspace globs; collegemap's leftover per-app file is redundant (its lockfile was already dropped in #41). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Ordered per-app cleanup steps + the gotchas learned validating slide. The knip $lib / ./$types issue is recorded as resolved upstream (webpro-nl/knip#1778, fixed in 6.16.1; patches/knip.patch bridges until adoption). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the non-slide, non-knip-version general fixes from the slide migration branch (task-178, PR #42) into main while #42 and #46 wait on knip 6.16.1 hitting npm.
Two clean commits:
chore(workspaces)— drop collegemap's strayapps/collegemap/pnpm-workspace.yaml(root workspace owns all globs; the lockfile was already dropped in chore: drop stray apps/collegemap/pnpm-lock.yaml [task-194] #41, this is the leftover).docs(migration)— backport the per-app cleanup checklist + gotchas learned validating slide. The old "knip doesn't resolve$lib/./$types" open-issue line is updated to record the resolution (🐛 SvelteKit monorepos no longer resolve ./$types webpro-nl/knip#1778, fixed upstream in 6.16.1;patches/knip.patchbridges until we adopt it).Deliberately NOT included (entangled with the knip-on-npm wait, would be churn to add then drop in days): the
patches/knip.patchtrio (ed3280c/5ef31d5/c78c426). Those ride with the clean patch-drop once 6.16.1 publishes.No code/build changes — a doc and a redundant config file. Safe to land independently of the cutover.
🤖 Generated with Claude Code