migrate: CollegeMap -> apps/collegemap#3
Merged
Merged
Conversation
- Implemented GET endpoint for college info with caching from Wikipedia. - Added event streaming API for real-time updates. - Created geocoding API using Nominatim for location searches. - Developed login and signup pages with form validation and session management. - Created user profile page for college selection and logout functionality. - Added Tailwind CSS for styling and layout improvements. - Configured SvelteKit with necessary adapters and TypeScript support. - Included robots.txt for search engine crawling permissions.
…roject references
PetalCat
pushed a commit
that referenced
this pull request
May 31, 2026
Per Eli's review of #3: - renovate.json -> .github/renovate.json - knip: drop entry/ignore overrides; trust framework detection (only the root vite.config.ts declared as entry — vite+ consumes it, knip can't tell) - .gitignore: cleaned (it's recursive by default; dropped redundant **/ + noise) - .vscode/settings.json -> settings.example.json (VSCode has no settings.local.json) - lint: plain oxlint + eslint (vp lint has an alpha vite-config-discovery crash on nested SvelteKit; oxfmt via vp fmt still used) - .oxlintrc.json: removed the apps/** rule-relaxing override collegemap lint errors FIXED, not suppressed (codex, verified): - deleted empty src/lib/index.ts (no bare $lib imports) - searchInputEl / mapContainer -> $state<...>() for Svelte 5 bind:this - +page.svelte: real bug — `liveUsers = liveUsers` no-op replaced with proper replace-or-append on the SSE user-added event (new users now actually appear) - auth.ts: hashPassword un-exported (only used internally) - eslint.config.ts: named import { configs } from eslint-plugin-package-json CI: DATABASE_URL stub moved to workflow-level env so knip can load drizzle.config.
added 5 commits
May 30, 2026 22:46
Rename-only. Not pushed back to PetalNet/CollegeMap; only feeds the merge into PetalNet/Monorepo.
Source: github.com/PetalNet/CollegeMap @ main, history preserved with original authors + dates. `git log --follow apps/collegemap/...` walks back through the pre-move tree. Originals stay live in PetalNet/CollegeMap until cutover.
Pure formatter pass over the migrated CollegeMap source. No logical changes. Recorded in .git-blame-ignore-revs.
- scope package name to @petalnet/collegemap; drop prettier (repo uses oxfmt/oxlint) and redundant per-app .npmrc; sort scripts (eppj) - Svelte 5: make bind:this targets (searchInputEl, mapContainer) $state and guard map init against an undefined container - fix live-user SSE handler: it self-assigned (liveUsers = liveUsers) so newly-added users never rendered; now does a real replace-or-append - use non-mutating toSorted() for ranking/timeline sorts - rename a shadowed `users` param; un-export internal-only hashPassword; delete empty $lib/index stub and the now-unneeded app.d.ts empty export - allow CSS side-effect imports in oxlint; exclude college data files from the spell checker (university names trip false positives)
4c7da61 to
1fcb8d7
Compare
lishaduck
approved these changes
May 31, 2026
lishaduck
left a comment
Member
There was a problem hiding this comment.
DM'd some followups but lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
PetalNet/CollegeMapintoapps/collegemap/with history preserved, re-cut cleanly onto the finalized monorepo toolchain.Commit structure
apps/collegemap/viagit merge --allow-unrelated-histories(untouched)..git-blame-ignore-revsso it won't pollute blame.@petalnet/collegemap; drop prettier (repo uses oxfmt/oxlint) + redundant per-app.npmrc; sort scripts (eppj)bind:thistargets (searchInputEl,mapContainer) ->$state, guard map initliveUsers = liveUsers) so newly-added users never rendered -> proper replace-or-appendtoSorted(); un-export internal-onlyhashPassword; drop empty$lib/indexstubVerified green in docker (node 26 + pnpm 11.5,
DATABASE_URLstub)oxlint
--max-warnings=0, eslint--max-warnings=0, svelte-check (0 errors),pnpm -r build, knip, manypkg.