Add tests for X509Crl and X509CrlGenerator#127
Merged
donskov merged 3 commits intoPeculiarVentures:masterfrom Mar 20, 2026
Merged
Add tests for X509Crl and X509CrlGenerator#127donskov merged 3 commits intoPeculiarVentures:masterfrom
donskov merged 3 commits intoPeculiarVentures:masterfrom
Conversation
microshine
requested changes
Feb 11, 2026
Contributor
Author
|
Sorry about that, I'm not sure how it ended up with U+200D (Zero Width Joiner) in the file name. |
Collaborator
|
@microshine Please check again when you have a time. |
microshine
pushed a commit
that referenced
this pull request
May 1, 2026
X509Crl.tbs (src/x509_crl.ts:175) and X509Certificate.tbs (src/x509_cert.ts:251) are both `private` by design — the ToBeSigned block is an implementation detail of verify(). The assertion in test/x509_crl.ts:59 violates that encapsulation and emits TS2341 under `tsc --noEmit`. CI's `npm run coverage` uses vitest's transpile-only path which skips visibility checks, so this slipped through review of #127. The remaining assertions in the same test already exercise the underlying tbsCertList structure (issuer, thisUpdate, nextUpdate, signatureAlgorithm, signature), so removing the line does not reduce meaningful coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests