Skip to content

Add tests for X509Crl and X509CrlGenerator#127

Merged
donskov merged 3 commits intoPeculiarVentures:masterfrom
aww-aww:patch-1
Mar 20, 2026
Merged

Add tests for X509Crl and X509CrlGenerator#127
donskov merged 3 commits intoPeculiarVentures:masterfrom
aww-aww:patch-1

Conversation

@aww-aww
Copy link
Copy Markdown
Contributor

@aww-aww aww-aww commented Feb 6, 2026

Add tests

Comment thread test/x509_crl.ts‎ Outdated
@aww-aww
Copy link
Copy Markdown
Contributor Author

aww-aww commented Feb 11, 2026

Sorry about that, I'm not sure how it ended up with U+200D (Zero Width Joiner) in the file name.

@donskov donskov requested a review from microshine March 16, 2026 15:13
@donskov
Copy link
Copy Markdown
Collaborator

donskov commented Mar 16, 2026

@microshine Please check again when you have a time.

@donskov donskov merged commit 4954092 into PeculiarVentures:master Mar 20, 2026
1 of 3 checks passed
microshine pushed a commit that referenced this pull request May 1, 2026
X509Crl.tbs (src/x509_crl.ts:175) and X509Certificate.tbs
(src/x509_cert.ts:251) are both `private` by design — the
ToBeSigned block is an implementation detail of verify().

The assertion in test/x509_crl.ts:59 violates that encapsulation
and emits TS2341 under `tsc --noEmit`. CI's `npm run coverage`
uses vitest's transpile-only path which skips visibility checks,
so this slipped through review of #127.

The remaining assertions in the same test already exercise the
underlying tbsCertList structure (issuer, thisUpdate, nextUpdate,
signatureAlgorithm, signature), so removing the line does not
reduce meaningful coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants