src/Metadata/class-front-page-builder.php (1)

27-27: Update the version number in the documentation.

The comment indicates this needs to be updated for the actual release version instead of the placeholder "3.20.7".

- * @since 3.20.7 - this needs to be updated as per version in which this will be released.
+ * @since 3.21.0

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

src/Metadata/class-front-page-builder.php (1)

24-32: Normalize @SInCE version; consider property typing (if PHP ≥ 7.4).

• Use full semantic version to match project style (e.g., 3.4.0 elsewhere).
• Optional: add a typed property if plugin’s minimum PHP is 7.4+.

Apply:

-	 * @since 3.21
+	 * @since 3.21.0

If PHP ≥ 7.4:

-	private $post;
+	private WP_Post $post;

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

tests/Integration/TestCase.php (3)

263-274: Prefer factory->post->create_and_get() and drop unreachable WP_Error check.

Simplifies the fallback and avoids an extra get_post() call. The factory create() doesn’t return WP_Error for posts.

-		if ( ! $post_obj instanceof WP_Post ) {
-			// Need to return post object, so if it's not WP_Post then create one.
-			$new_post_id = self::factory()->post->create();
-			if ( is_wp_error( $new_post_id ) ) {
-				throw new UnexpectedValueException( 'Failed to create a new post.' );
-			}
-			$post_obj = get_post( $new_post_id );
-			if ( ! $post_obj instanceof WP_Post ) {
-				throw new UnexpectedValueException( 'Failed to get the newly created post.' );
-			}
-		}
+		if ( ! $post_obj instanceof WP_Post ) {
+			// Ensure a WP_Post is returned in tests; create one when absent.
+			$post_obj = self::factory()->post->create_and_get();
+			if ( ! $post_obj instanceof WP_Post ) {
+				throw new UnexpectedValueException( 'Failed to create and retrieve a WP_Post.' );
+			}
+		}

---

263-274: Docblock should include null in $post_id type.

Method accepts null (Line 249) but the @param omits it. Add |null to reflect reality.

/**
 * @param int|WP_Error|null $post_id Optional. Defaults to global $post.
 */

---

263-274: Explicitly create posts in tests instead of relying on fallback.

Fallback in get_post() silently creates a new post when none is provided, which can mask misconfigured test inputs. Update these call sites to use an explicit factory call:

• tests/Integration/Metadata/TermArchiveTest.php:64 – replace $this->get_post() with

  $post_id   = self::factory()->post->create();
  $post_obj  = get_post( $post_id );

• tests/Integration/Metadata/CustomPostTypeArchiveTest.php:81 – same replacement
• tests/Integration/Metadata/AuthorArchiveTest.php:67 – same replacement
• tests/Integration/Metadata/GetCurrentUrlTest.php:135,169 – replace $this->get_post( 0 ) with an explicit post creation and use that ID

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

tests/Integration/Metadata/GetCurrentUrlTest.php (3)

133-137: Add period to end of inline comment (WP coding standards).

Ensure each line comment ends with a period.

-		// Using Category_Builder since we can't instantiate abstract
+		// Using Category_Builder since we can't instantiate abstract.

---

150-155: Fail fast: assert WP_Post before constructing Front_Page_Builder.

Improves test clarity if post creation ever fails.

-		$builder         = new Front_Page_Builder( new Parsely(), $this->get_post( $post_id ) );
+		$post            = $this->get_post( $post_id );
+		self::assertInstanceOf( \WP_Post::class, $post );
+		$builder         = new Front_Page_Builder( new Parsely(), $post );

---

167-171: Add period to end of inline comment (WP coding standards).

Same nit as above.

-		// Using Category_Builder since we can't instantiate abstract
+		// Using Category_Builder since we can't instantiate abstract.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

tests/Integration/Metadata/GetCurrentUrlTest.php (3)

133-137: Fix inline comment style; end with a period and avoid broken sentence.

Unify the two-line comment into one sentence and terminate with a period to match project/WP standards.

-		// Using Category_Builder since we can't instantiate abstract
-		// Metadata_Builder.
+		// Using Category_Builder since we can't instantiate the abstract Metadata_Builder.

---

150-154: Apply the same comment cleanup here.

Keep the comment to a single, punctuated line.

-		// Using Category_Builder since we can't instantiate abstract
-		// Metadata_Builder.
+		// Using Category_Builder since we can't instantiate the abstract Metadata_Builder.

---

167-171: Repeat the comment style fix for consistency.

-		// Using Category_Builder since we can't instantiate abstract
-		// Metadata_Builder.
+		// Using Category_Builder since we can't instantiate the abstract Metadata_Builder.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

src/Metadata/class-front-page-builder.php (1)

23-31: Docblock tweaks: version format and stray blank line.

Use 3-part version to match existing @SInCE usage and remove the blank line flagged previously.

Apply:

 	/**
 	 * Post object to generate the metadata for.
 	 *
-	 * @since 3.21
-	 * 
+	 * @since 3.21.0
 	 * @var WP_Post
 	 */
 	private $post;

tests/e2e/specs/front-end-metadata.spec.ts (4)

56-62: Parse JSON-LD instead of brittle string contains.

Use DOM selection + JSON parse to assert structure; this is more robust across host/port/scheme changes.

Apply:

-		expect( content ).toContain( '<script type="application/ld+json" class="wp-parsely-metadata">' );
-		expect( content ).toContain( '"@context":"https:\\/\\/schema.org"' );
-		expect( content ).toContain( '"@type":"WebPage"' );
-		expect( content ).toContain( '"headline":"wp-parsely"' );
-		expect( content ).toContain( '"url":"http:\\/\\/localhost:8889"' );
-		expect( content ).not.toContain( '<meta name="parsely-title"' );
+		const json = await page.locator( 'script.wp-parsely-metadata' ).textContent();
+		expect( json ).not.toBeNull();
+		const data = JSON.parse( json! );
+		expect( data['@context'] ).toBe( 'https://schema.org' );
+		expect( data['@type'] ).toBe( 'WebPage' );
+		expect( data.headline ).toBe( 'wp-parsely' );
+		expect( new URL( data.url ).origin ).toBe( new URL( page.url() ).origin );
+		expect( content ).not.toContain( '<meta name="parsely-title"' );

---

111-114: Tighten ISO8601 assertion for pub-date.

Anchor to strict Zulu timestamp to avoid accidental matches.

Apply:

-		expect( content ).toMatch( /<meta name="parsely-pub-date" content=".*Z">/ );
+		expect( content ).toMatch( /<meta name="parsely-pub-date" content="\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z">/ );

---

190-194: Use visitAdminPage params instead of embedding query into path.

Improves readability and consistency with @wordpress/e2e-test-utils-playwright conventions.

Apply:

-		await this.admin.visitAdminPage( '/admin.php?page=parsely-settings&e2e_parsely_skip_api_validate=y' );
+		await this.admin.visitAdminPage( 'admin.php', 'page=parsely-settings&e2e_parsely_skip_api_validate=y' );

---

38-41: Centralize settings-page URL with skip flag
Multiple e2e specs (front-end-metadata.spec.ts, plugin-action-link.spec.ts, browse-logo-button.spec.ts, activation-flow.spec.ts, settings-track-post-types-as.spec.ts) hardcode the /wp-admin/admin.php?page=parsely-settings URL and the &e2e_parsely_skip_api_validate=y flag. Extract a shared SETTINGS_URL constant (for example, in tests/e2e/utils.ts) and import it in each spec for both page.goto(…) and admin.visitAdminPage(…) calls to ensure consistency and DRYness.

src/Metadata/class-front-page-builder.php (1)

32-41: Add @SInCE tag to constructor docblock.

Keeps API docs consistent.

Apply:

 	/**
 	 * Constructor.
 	 *
+	 * @since 3.21.0
+	 *
 	 * @param Parsely $parsely Instance of Parsely class.
 	 * @param WP_Post $post Post object to generate the metadata for.
 	 */

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

tests/e2e/specs/front-end-metadata.spec.ts (1)

190-190: Remove the e2e_parsely_skip_api_validate flag; tests should pass without it.

This bypass reduces fidelity and was already flagged in review.

-		await this.admin.visitAdminPage( '/admin.php?page=parsely-settings&e2e_parsely_skip_api_validate=y' );
+		await this.admin.visitAdminPage( '/admin.php?page=parsely-settings' );

Run to confirm no stray uses:

#!/bin/bash
rg -n "e2e_parsely_skip_api_validate"

tests/e2e/specs/front-end-metadata.spec.ts (2)

56-61: Make homepage JSON-LD assertions resilient (parse DOM JSON instead of substring).

String contains checks are brittle (escaping/order). Parse the script content and assert structure with locators.

-		expect( content ).toContain( '<script type="application/ld+json" class="wp-parsely-metadata">' );
-		expect( content ).toContain( '"@context":"https:\\/\\/schema.org"' );
-		expect( content ).toContain( '"@type":"WebPage"' );
-		expect( content ).toContain( '"headline":"wp-parsely"' );
-		expect( content ).toContain( '"url":"http:\\/\\/localhost:8889"' );
-		expect( content ).not.toContain( '<meta name="parsely-title"' );
+		await expect( page.locator( 'script.wp-parsely-metadata' ) ).toHaveCount( 1 );
+		const raw = await page.locator( 'script.wp-parsely-metadata' ).first().textContent();
+		const data = JSON.parse( String( raw ) );
+		const nodes = Array.isArray( data ) ? data : [ data ];
+		const webPage = nodes.find( ( n ) => n['@type'] === 'WebPage' ) || nodes[0];
+		expect( webPage['@context'] ).toBe( 'https://schema.org' );
+		expect( webPage['@type'] ).toBe( 'WebPage' );
+		expect( webPage.headline ).toBeTruthy();
+		expect( webPage.url ).toMatch( /^http:\/\/localhost:8889/ );
+		expect( content ).not.toContain( '<meta name="parsely-title"' );

---

111-113: Reduce flakiness in homepage metas (assert existence, not env-specific values).

Values like “Uncategorized” and “admin” vary by locale/fixtures; assert presence and basic format instead.

-		expect( content ).toMatch( /<meta name="parsely-pub-date" content=".*Z">/ );
-		expect( content ).toContain( '<meta name="parsely-section" content="Uncategorized">' );
-		expect( content ).toContain( '<meta name="parsely-author" content="admin">' );
+		await expect( page.locator( 'meta[name="parsely-pub-date"]' ) ).toHaveCount( 1 );
+		const pubDate = await page.locator( 'meta[name="parsely-pub-date"]' ).first().getAttribute( 'content' );
+		expect( pubDate ).toMatch( /Z$/ );
+		await expect( page.locator( 'meta[name="parsely-section"]' ) ).toHaveCount( 1 );
+		await expect( page.locator( 'meta[name="parsely-author"]' ) ).toHaveCount( 1 );

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

src/Metadata/class-front-page-builder.php (1)

23-31: Type the property and normalize the DocBlock.

Add a typed property for stronger contracts and align the @since format; also remove the extra blank line between tags.

Apply:

 	/**
 	 * Post object to generate the metadata for.
 	 *
-	 * @since 3.21
-	 *
-	 * @var WP_Post
+	 * @since 3.21.0
+	 * @var WP_Post
 	 */
-	private $post;
+	private WP_Post $post;

src/Metadata/class-front-page-builder.php (1)

84-86: Optional: canonical trailing slash.

If the rest of the codebase expects a trailing slash on homepage URLs, consider home_url( '/' ) for consistency.

-		$this->metadata['url'] = home_url();
+		$this->metadata['url'] = home_url( '/' );

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

src/Metadata/class-front-page-builder.php (1)

23-31: Align @SInCE version and property nullability.

DocBlocks say @SInCE 3.20.7, but PR discussion mentions the next release. Please confirm and update to the correct target version for both the property and constructor to avoid future churn. If you later decide to make $post optional for BC, update @var to WP_Post|null.

Suggested diff (if release is 3.21.0):

- * @since 3.20.7
+ * @since 3.21.0

src/Metadata/class-front-page-builder.php (1)

32-43: Document BC break and consider optional $post fallback. Only two internal instantiations were found (src/class-metadata.php lines 94, 99), so internal usage is safe. Add a note in the changelog about making $post a required constructor parameter. Optionally, for smoother third-party migrations, revert to ?WP_Post $post = null with a fallback to the queried object or front page post.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

src/Metadata/class-front-page-builder.php (4)

23-31: Property DocBlock added — good. Please verify @SInCE version.

The DocBlock is clear. Confirm that “3.20.7” matches the release this change will ship in.

---

23-31: Nit: remove the blank line between tags in the property DocBlock.

Drop the empty line between @SInCE and @var for consistency with prior feedback.

 	/**
 	 * Post object to generate the metadata for.
 	 *
 	 * @since 3.20.7
-	 *
 	 * @var WP_Post
 	 */

---

32-43: Constructor signature change — verify external usages and BC.

Ensure all instantiations pass the WP_Post argument and that no third-party code constructs this without the new param.

#!/bin/bash
# Find all constructor call sites.
rg -nP -C2 '\bnew\s+Front_Page_Builder\s*\('

---

32-43: Nit: tighten constructor DocBlock formatting.

Remove the blank line between @SInCE and @param tags.

 	/**
 	 * Constructor.
 	 *
 	 * @since 3.20.7
-	 *
 	 * @param Parsely $parsely Instance of Parsely class.
 	 * @param WP_Post $post    Post object to generate the metadata for.
 	 */

src/Metadata/class-front-page-builder.php (1)

58-67: Anchor mainEntityOfPage to the canonical homepage URL and avoid empty JSON-LD fields.

Using get_current_url('non-post') may diverge from build_url() (trailing slash or query string), leading to url/@id mismatch. Also, emitting empty image fields degrades schema quality.

 		if ( true === $this->parsely->get_options()['full_metadata_in_non_posts'] ) {
-			$this->build_main_entity( 'non-post' );
+			$this->build_main_entity( 'non-post' );
+			// Ensure @id matches the canonical homepage URL used in build_url().
+			$this->metadata['mainEntityOfPage']['@id'] = $this->metadata['url'];
 			$this->build_thumbnail_url( $this->post );
 			$this->build_image( $this->post );
 			$this->build_article_section( $this->post );
 			$this->build_author( $this->post );
 			$this->build_publisher();
 			$this->build_keywords( $this->post );
 			$this->build_metadata_post_times( $this->post );
+			// Prune empty fields to keep JSON-LD clean.
+			if ( isset( $this->metadata['thumbnailUrl'] ) && '' === $this->metadata['thumbnailUrl'] ) {
+				unset( $this->metadata['thumbnailUrl'] );
+			}
+			if ( isset( $this->metadata['image']['url'] ) && '' === $this->metadata['image']['url'] ) {
+				unset( $this->metadata['image'] );
+			}
+			if ( isset( $this->metadata['articleSection'] ) && '' === $this->metadata['articleSection'] ) {
+				unset( $this->metadata['articleSection'] );
+			}
 		}

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro