Fix AmberParm.from_structure with CMAPs#1233
Merged
Merged
Conversation
This was referenced Feb 18, 2022
Closed
swails
added a commit
to swails/ParmEd
that referenced
this pull request
Feb 18, 2022
* Add a test that fails with the current bug * Fix the bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AmberParm.from_structure would fail when converting a topology of some sort that contained only a CMAP, despite this being a now-supported potential term in canonical Amber topology files.
This was already properly supported when reading Amber topology files, but not when converting from another format. This adds a test and fixes that shortcoming.
Fixes #1228