Fix/openmm namespace change#1176
Merged
Merged
Conversation
This was referenced Jun 15, 2021
swails
pushed a commit
to swails/ParmEd
that referenced
this pull request
Aug 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like #1173 this PR address the namespace changes coming to openMM, but does this in a backwards compatible way. The main issue I ran into using the openMM dev build was the logic on how parmed checks the version/capabilities of openMM.
I'm not sure when the next parmed release is planned, but this change is backwards compatible with other openmm versions and perhaps is a good stopgap for users that want to use the latest version of both openmm and parmed.