Drop Python 3.8, 3.9 support and expand CI unit testing #1658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Drop support for Python 3.8 and 3.9 - Adapt workflows to accept python-version param, and update matrix - Update installation.rst with min Python version
Prior behaviour didn't require x and y to be same length. PEP618 in Python 3.10 introduced strict flag. True raises ValueError if x and y aren't same length. Setting values here based on intuition. This was flagged by Bugbear in Ruff checks (B905)
erikvansebille
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement SPEC 0 (fixes #1657).
not sure if we want to go that far though. Thoughts @erikvansebille?Should just be a matter of copying a script across and setting it to run twice a year. Why not I guess, just a matter of deciding what core packages count as (xarray, zarr, pandas, numpy?). Wouldn't mind leaving this for a future PR. Getting the current changes intomasterallows me to work with python 3.10 features (re. typing) next week