Skip to content

Update the icon for GNOME Firmware and more#3502

Merged
SmartFinn merged 6 commits intoPapirusDevelopmentTeam:masterfrom
morganist:gnome-firmware
Aug 1, 2023
Merged

Update the icon for GNOME Firmware and more#3502
SmartFinn merged 6 commits intoPapirusDevelopmentTeam:masterfrom
morganist:gnome-firmware

Conversation

@morganist
Copy link
Member

@morganist morganist commented Jul 31, 2023

Updated GNOME Firmware icon to a new version (closes #2392):

image

It is based on the Gtkstresstesting icon, but recoloured to represent a green pcb instead of a red one;
Introduced gst.svg (copied from com.leinardi.gst.svg);
Made gst.svg the main Gtkstresstesting icon because it is the name of its native (non-flatpak) executable;
Tweaked gst.svg (Gtkstresstesting icon): tweaked shadows, added a shadow and an outline on the chip;
Symlinked com.leinardi.gst.svg to gst.svg;
Introduced gnome-firmware.svg (copied from com.gnome.Firmware.svg);
Made gnome-firmware.svg the main GNOME Firmware icon because it is the name of its native (non-flatpak) executable;
Symlinked firmware-manager.svg and application-x-firmware.svg to gnome-firmware.svg instead of com.gnome.Firmware.svg;
And of course, symlinked com.gnome.Firmware.svg to gnome-firmware.svg;

@morganist
Copy link
Member Author

Is this even the right way to symlink things? I don't quite understand the difference between executable names, desktop file names and flatpak apps names. But in general i see that the majority of icons is named like their executable names, not flathub/flatpak/desktop filenames - these are symlinked. It is quite hard, to be honest... I just want to help clearing this mess up.

@SmartFinn
Copy link
Member

@morganist no matter what name you use for an icon, or what you use for symlink. But when you choose between a common name (e.g. disk-usage-analyzer) and an app name (e.g. filelight), the common name should be chosen.

@morganist
Copy link
Member Author

i just think it simplefies things — it is easier to search for an icon when the source icon (not a symlink) is not named "comnetorg.developer.longappname" or something

@SmartFinn
Copy link
Member

SmartFinn commented Aug 1, 2023

I'll be preferred to keep the old org.gnome.Firmware.svg icon as application-x-firmware.svg. I'll do it myself, so there's no need to do anything.

@SmartFinn SmartFinn merged commit eb19f4b into PapirusDevelopmentTeam:master Aug 1, 2023
@morganist morganist deleted the gnome-firmware branch August 1, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Icon request] Firmware

2 participants