Skip to content

Update VSCodium icon#3402

Merged
SmartFinn merged 1 commit intoPapirusDevelopmentTeam:masterfrom
cavcrosby:update-vscodium-icon
May 8, 2023
Merged

Update VSCodium icon#3402
SmartFinn merged 1 commit intoPapirusDevelopmentTeam:masterfrom
cavcrosby:update-vscodium-icon

Conversation

@cavcrosby
Copy link
Contributor

Fulfills #3401.

@SmartFinn
Copy link
Member

Thanks for the contribution. There are a couple issues with this icon:

  1. Missing margins, without it the icons feel much bigger than others. See Basic concepts and templates at tools/work/Papirus/apps
  2. Papirus icons shouldn't use any gradient.

@cavcrosby
Copy link
Contributor Author

cavcrosby commented Apr 3, 2023

I believe I have addressed the points you've made @SmartFinn.

Will add that I decided to make the icon color blue based on what's given in the example colors SVG (tools/work/examples-papirus.svg), I think this color is brighter and "pops" better in appearance vs the original.

@SmartFinn
Copy link
Member

Sorry for the late reply.

There is one major issue with these icons, edges of objects should be snapping to the pixel grid. 48px icon is mostly ok, but others icons, especially the 16-32px are blurry.

Here are a couple examples where is ok, and where is bad:

image
image
image

@hervyqa
Copy link

hervyqa commented Apr 25, 2023

@cavcrosby great work!.
i prefer to keep the white circle, but inside it with the new blue logo.

@cavcrosby
Copy link
Contributor Author

In this latest attempt, I've tried to pixel align the edges of objects to the grid in some manner, but unfortunately the geometric shaping of the icon makes perfecting pixel alignment about impossible. If that isn't acceptable, then I can close the PR and let someone else take a crack at it.

@SmartFinn
Copy link
Member

@cavcrosby thank you for your patience 😄 It looks a good enough. I'll merge it when I'll have time to fix minor issues.

@SmartFinn SmartFinn merged commit 0e8d73a into PapirusDevelopmentTeam:master May 8, 2023
SmartFinn added a commit that referenced this pull request May 8, 2023
@cavcrosby cavcrosby deleted the update-vscodium-icon branch May 8, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants