src/shared-components/EventForm/EventForm.spec.tsx (4)

222-224: ⚠️ Potential issue | 🟠 Major

❌ BLOCKING — Use vi.restoreAllMocks() and add cleanup() in afterEach.

vi.clearAllMocks() only clears call history but keeps mock implementations, causing mock leakage between tests in parallel shards. Also, cleanup() from @testing-library/react is missing.

Proposed fix

+import { render, screen, act, waitFor, cleanup } from '@testing-library/react';
-import { render, screen, act, waitFor } from '@testing-library/react';

  afterEach(() => {
-   vi.clearAllMocks();
+   cleanup();
+   vi.restoreAllMocks();
  });

As per coding guidelines: "❌ BLOCKING - Use vi.restoreAllMocks() at file:line" and "❌ BLOCKING - Missing required cleanup at file:line".

---

76-76: ⚠️ Potential issue | 🟠 Major

🔴 NON-DETERMINISTIC TIMESTAMP at Line 76 — dayjs() without arguments in mock.

dayjs().format('YYYY-MM-DD') captures current time, causing flakiness in sharded CI. Use a fixed UTC string instead.

Proposed fix

-     const today = dayjs().format('YYYY-MM-DD');
+     const today = '2025-06-15';

As per coding guidelines: dayjs() without arguments is a forbidden pattern — "Replace with fixed UTC string".

---

198-199: ⚠️ Potential issue | 🟠 Major

🔴 NON-DETERMINISTIC TIMESTAMPS — dayjs() without arguments for test data.

Lines 198-199 use dayjs().add(...) which captures current time. These should use fixed UTC dates for deterministic test behavior across CI shards.

The same pattern recurs at lines 253, 261, 315, 357, 401, 410, 454-456, 486, 500, 609-610, 653-654, 701, 1072-1073, 1118-1119, 1164-1165, 1208-1209, 1247-1248, 1288-1289, 1489, 1513-1514, 1612-1613, 1654-1655, 1696-1697, 1738-1739, 1818-1819, 1905-1906, and the mock callbacks at lines 131-134, 157.

Example fix for top-level dates

-const futureStartDate = dayjs().add(30, 'day').startOf('day').toDate();
-const futureEndDate = dayjs().add(31, 'day').startOf('day').toDate();
+const futureStartDate = new Date('2027-06-15T00:00:00.000Z');
+const futureEndDate = new Date('2027-06-16T00:00:00.000Z');

As per coding guidelines: "dayjs() without arguments" and "new Date() without arguments" are forbidden patterns.

---

238-246: ⚠️ Potential issue | 🟠 Major

🔴 RACE CONDITION — Assertion outside waitFor after async user.click.

expect(handleSubmit).toHaveBeenCalledWith(...) at line 239 follows await user.click(...) at line 238 but is not wrapped in waitFor. This pattern recurs extensively throughout the file (e.g., lines 278, 338, 380, 427, 479, 534, 554, 574, 602, 641, 679, 711, 737, 763, 787, 935, 950, 964, 995, 1024, 1061, 1107, 1153, 1199, 1243, 1351, 1447, 1465, 1643, 1685, 1727, 1769, 1963, 1992).

Example fix:

 await user.click(screen.getByTestId('createEventBtn'));
-expect(handleSubmit).toHaveBeenCalledWith(
+await waitFor(() => expect(handleSubmit).toHaveBeenCalledWith(
   expect.objectContaining({ name: 'Test Event' }),
-);
+));

As per coding guidelines: "❌ BLOCKING - Race condition — Assertion outside waitFor block after async operation".

src/shared-components/EventForm/RecurrenceDropdown/RecurrenceDropdown.spec.tsx (1)

30-36: ⚠️ Potential issue | 🟠 Major

❌ BLOCKING — Use vi.restoreAllMocks() and add cleanup() in afterEach.

Both beforeEach and afterEach use vi.clearAllMocks(). The afterEach must use vi.restoreAllMocks() and include cleanup() to prevent mock leakage and DOM pollution across sharded tests.

Proposed fix

+import { render, screen, cleanup } from '@testing-library/react';
-import { render, screen } from '@testing-library/react';

  afterEach(() => {
-   vi.clearAllMocks();
+   cleanup();
+   vi.restoreAllMocks();
  });

As per coding guidelines: "❌ BLOCKING - Use vi.restoreAllMocks()" and "❌ BLOCKING - Missing required cleanup".

src/shared-components/EventForm/RecurrenceDropdown/RecurrenceDropdown.spec.tsx (2)

34-36: ⚠️ Potential issue | 🟠 Major

❌ BLOCKING — Missing cleanup() and uses vi.clearAllMocks() instead of vi.restoreAllMocks().

The afterEach block is missing cleanup() from @testing-library/react and uses vi.clearAllMocks() which only clears call history but keeps mock implementations, risking mock leakage between tests in parallel shards.

Proposed fix

+import { render, screen, waitFor, cleanup } from '@testing-library/react';
-import { render, screen, waitFor } from '@testing-library/react';
 ...
  afterEach(() => {
-   vi.clearAllMocks();
+   cleanup();
+   vi.restoreAllMocks();
  });

As per coding guidelines: "❌ BLOCKING - Missing required cleanup" and "❌ BLOCKING - Use vi.restoreAllMocks() instead of vi.clearAllMocks()".

---

30-32: ⚠️ Potential issue | 🟠 Major

beforeEach should also use vi.restoreAllMocks().

Same reasoning — vi.clearAllMocks() only resets call counts/arguments but leaves mock implementations intact.

Proposed fix

  beforeEach(() => {
-   vi.clearAllMocks();
+   vi.restoreAllMocks();
  });

As per coding guidelines: "vi.clearAllMocks() only clears call history but keeps mock implementations. vi.restoreAllMocks() restores originals AND clears history."

src/shared-components/EventForm/RecurrenceDropdown/RecurrenceDropdown.spec.tsx (1)

30-36: ⚠️ Potential issue | 🔴 Critical

❌ BLOCKING — Use vi.restoreAllMocks() and add cleanup() in afterEach.

Two issues in the test lifecycle hooks:

1. vi.clearAllMocks() only resets call history but keeps mock implementations, causing mock leakage across sharded tests. Replace with vi.restoreAllMocks().
2. afterEach is missing cleanup() from @testing-library/react, which is required to tear down rendered components between tests.

Also, vi.restoreAllMocks() in afterEach makes the beforeEach clear redundant.

Proposed fix

-import { render, screen, waitFor } from '@testing-library/react';
+import { render, screen, waitFor, cleanup } from '@testing-library/react';

-  beforeEach(() => {
-    vi.clearAllMocks();
-  });
-
   afterEach(() => {
-    vi.clearAllMocks();
+    cleanup();
+    vi.restoreAllMocks();
   });

As per coding guidelines: "❌ BLOCKING - Use vi.restoreAllMocks() at file:line" and "❌ BLOCKING - Missing required cleanup at file:line".

src/screens/UserPortal/Events/Events.spec.tsx (4)

840-844: ⚠️ Potential issue | 🔴 Critical

❌ BLOCKING — Use vi.restoreAllMocks() and add cleanup() in afterEach.

vi.clearAllMocks() only resets call history but preserves mock implementations, causing leakage between sharded tests. Additionally, cleanup() from @testing-library/react is missing.

Proposed fix

+import { render, screen, waitFor, cleanup } from '@testing-library/react';
...
 afterEach(() => {
   localStorage.clear();
-  vi.clearAllMocks();
+  cleanup();
+  vi.restoreAllMocks();
   vi.useRealTimers();
 });

As per coding guidelines: "❌ BLOCKING - Use vi.restoreAllMocks() at file:line" and "❌ BLOCKING - Missing required cleanup at file:line". Based on learnings, enforce explicit cleanup of testing-library/react in test files.

---

811-817: ⚠️ Potential issue | 🟠 Major

🔴 HARDCODED DELAY — wait() helper wraps setTimeout with fixed durations.

This helper is used ~15 times throughout the file (lines 864, 889, 996, 1113, 1159, 1184, 1214, etc.) and is the primary source of CI flakiness. Replace with waitFor assertions or findBy* queries.

As per coding guidelines: "🔴 HARDCODED DELAY at file:line — Replace with waitFor assertion".

---

227-238: ⚠️ Potential issue | 🟠 Major

🔴 NON-DETERMINISTIC TIMESTAMP and local timezone methods.

Line 227: dayjs() captures current time before vi.setSystemTime runs in beforeEach, so TEST_DATE is computed from the actual system clock at module load, not the mocked time. Lines 237–238 use .getMonth() and .getFullYear() (local timezone methods), which cause CI flakiness in non-UTC environments.

Proposed fix

-const TEST_DATE = dayjs()
-  .year(2024)
-  .month(5)
-  .date(15)
-  .hour(8)
-  .minute(0)
-  .second(0)
-  .millisecond(0)
-  .toISOString();
-const dateObj = new Date(TEST_DATE);
-const currentMonth = dateObj.getMonth();
-const currentYear = dateObj.getFullYear();
+const TEST_DATE = '2024-06-15T08:00:00.000Z';
+const dateObj = new Date(TEST_DATE);
+const currentMonth = dateObj.getUTCMonth();
+const currentYear = dateObj.getUTCFullYear();

As per coding guidelines: "🔴 NON-DETERMINISTIC TIMESTAMP — Replace with fixed UTC string" and "Flag ANY usage of local timezone methods as CRITICAL".

---

1819-1822: ⚠️ Potential issue | 🟡 Minor

🔴 NON-DETERMINISTIC TIMESTAMP and local timezone method at test scope.

new Date() on line 1820 and today.getDay() on line 1822 capture the real system time and use a local timezone method. Since vi.setSystemTime is set in beforeEach, new Date() inside a test should return the mocked time, but .getDay() is still a local timezone method that can differ from UTC day.

Proposed fix

-    const today = new Date();
-    const weekDayByJs = ['SU', 'MO', 'TU', 'WE', 'TH', 'FR', 'SA'];
-    const dayOfWeek = today.getDay();
+    const today = new Date(TEST_DATE);
+    const weekDayByJs = ['SU', 'MO', 'TU', 'WE', 'TH', 'FR', 'SA'];
+    const dayOfWeek = today.getUTCDay();

As per coding guidelines: "❌ NEVER use: .getDay()" and "Use fixed UTC timestamps".

src/screens/AdminPortal/OrganizationEvents/CreateEventModal.spec.tsx (3)

318-326: ⚠️ Potential issue | 🔴 Critical

❌ BLOCKING — Use vi.restoreAllMocks() and add cleanup() in afterEach.

Both beforeEach and afterEach use vi.clearAllMocks() which only clears call history but keeps mock implementations. Additionally, cleanup() from @testing-library/react is missing, risking DOM leakage between tests.

Proposed fix

+import { render, screen, waitFor, cleanup } from '@testing-library/react';
...
 beforeEach(() => {
-  vi.clearAllMocks();
+  vi.restoreAllMocks();
   mockUseMutation.mockReturnValue([mockCreate, { loading: false }]);
   mockValidateRecurrenceInput.mockReturnValue({ isValid: true, errors: [] });
 });

 afterEach(() => {
-  vi.clearAllMocks();
+  cleanup();
+  vi.restoreAllMocks();
 });

As per coding guidelines: "❌ BLOCKING - Use vi.restoreAllMocks() at file:line" and "❌ BLOCKING - Missing required cleanup at file:line". Based on learnings, enforce explicit cleanup of testing-library/react in test files.

---

696-697: ⚠️ Potential issue | 🟠 Major

🔴 NON-DETERMINISTIC TIMESTAMP — dayjs() without arguments captures current time.

Lines 696–697 use dayjs() (no arguments) to generate test dates, which captures the real clock. Same pattern at lines 936–939, 1129–1130, and 1290–1291. Use a fixed UTC string instead.

Proposed fix

-    const futureStart = dayjs().add(10, 'days').format('YYYY-MM-DD');
-    const futureEnd = dayjs().add(11, 'days').format('YYYY-MM-DD');
+    const futureStart = dayjs('2025-01-01T10:00:00Z').add(10, 'days').format('YYYY-MM-DD');
+    const futureEnd = dayjs('2025-01-01T10:00:00Z').add(11, 'days').format('YYYY-MM-DD');

As per coding guidelines: "🔴 NON-DETERMINISTIC TIMESTAMP at file:line — Replace with fixed UTC string". Apply the same fix to lines 936–939, 1129–1130, and 1290–1291.

---

1465-1488: ⚠️ Potential issue | 🟠 Major

🔴 NON-DETERMINISTIC TIMESTAMP inside fake-timer block.

Line 1467 uses dayjs() without arguments. Even though vi.useFakeTimers() is active, the resulting now value depends on when the test runs relative to setSystemTime at line 1471. Build the mock date from a fixed string instead.

Proposed fix

     it('sets default start date to today 00:00 UTC (standard case)', () => {
-      const now = dayjs();
-      const mockDate = new Date(
-        Date.UTC(now.year(), now.month(), now.date(), 12, 0, 0),
-      );
+      const mockDate = new Date('2025-06-15T12:00:00.000Z');
+      const now = dayjs.utc(mockDate);
       vi.setSystemTime(mockDate);

As per coding guidelines: "🔴 NON-DETERMINISTIC TIMESTAMP at file:line — Replace with fixed UTC string".

src/shared-components/EventForm/RecurrenceDropdown/RecurrenceDropdown.spec.tsx (1)

30-36: ⚠️ Potential issue | 🔴 Critical

❌ BLOCKING — Use vi.restoreAllMocks() and add cleanup() in afterEach.

Both hooks use vi.clearAllMocks(). Per coding guidelines, vi.restoreAllMocks() is required to fully restore original implementations and prevent mock leakage across sharded tests. Also, cleanup() is missing.

Proposed fix

+import { render, screen, waitFor, cleanup } from '@testing-library/react';
...
 beforeEach(() => {
-  vi.clearAllMocks();
+  vi.restoreAllMocks();
 });

 afterEach(() => {
-  vi.clearAllMocks();
+  cleanup();
+  vi.restoreAllMocks();
 });

As per coding guidelines: "❌ BLOCKING - Use vi.restoreAllMocks() at file:line" and "❌ BLOCKING - Missing required cleanup at file:line". Based on learnings, enforce explicit cleanup of testing-library/react in test files.

src/shared-components/EventForm/RecurrenceDropdown/RecurrenceDropdown.spec.tsx (1)

30-36: ⚠️ Potential issue | 🔴 Critical

❌ BLOCKING — Use vi.restoreAllMocks() and add cleanup() in afterEach.

Two violations:

1. vi.clearAllMocks() only resets call history but preserves mock implementations, causing leakage across sharded tests. Replace with vi.restoreAllMocks().
2. afterEach is missing cleanup() from @testing-library/react, which is required to tear down rendered components between tests.

Proposed fix

+import { cleanup, render, screen, waitFor } from '@testing-library/react';
-import { render, screen, waitFor } from '@testing-library/react';

 ...

  beforeEach(() => {
-   vi.clearAllMocks();
+   vi.restoreAllMocks();
  });

  afterEach(() => {
-   vi.clearAllMocks();
+   cleanup();
+   vi.restoreAllMocks();
  });

As per coding guidelines: "❌ BLOCKING - Use vi.restoreAllMocks() at file:line" and "❌ BLOCKING - Missing required cleanup at file:line".