Skip to content

[fix]reducing length of Geofence vilations to prevent STATUSTEXT message length overrun#24719

Merged
dakejahl merged 1 commit intomainfrom
mavlink_geofence_messag_length_fix
Apr 25, 2025
Merged

[fix]reducing length of Geofence vilations to prevent STATUSTEXT message length overrun#24719
dakejahl merged 1 commit intomainfrom
mavlink_geofence_messag_length_fix

Conversation

@TomasTwardzik
Copy link
Copy Markdown
Contributor

@TomasTwardzik TomasTwardzik commented Apr 14, 2025

Solved Problem

Geofence breaching messages had been overrunning length of STATUSTEXT.text by a few characters. This may in some events lead to invalid character being displayed in GCS.

Solution

  • Geofence vionaliton notification popup typo

Changelog Entry

For release notes:

Shortening geofence viloation messages to fit STATUSTEXT.text field.

Context

Related links, screenshot before/after, video

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2025 •
edited
Loading

🔎 FLASH Analysis

px4_fmu-v5x [Total VM Diff: 144 byte (0.01 %)] 
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%    +144  +0.0%    +144    .text
  +0.0%    +136  +0.0%    +136    [section .text]
  +2.6%     +12  +2.6%     +12    ../../src/modules/commander/HealthAndArmingChecks/checks/geofenceCheck.cpp
  -0.1%      -4  -0.1%      -4    ../../src/modules/ekf2/EKF/yaw_estimator/EKFGSF_yaw.cpp
+0.0%     +56  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -8  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
+0.0%     +23  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
  +0.1%     +27  [ = ]       0    ../../src/modules/commander/HealthAndArmingChecks/checks/geofenceCheck.cpp
-0.0%     -23  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  -0.0%      -1  [ = ]       0    ../../src/modules/commander/HealthAndArmingChecks/checks/geofenceCheck.cpp
  +0.3%      +3  [ = ]       0    task/task_cancelpt.c
-0.0%     -29  [ = ]       0    .debug_loc
  -2.0%     -29  [ = ]       0    ../../src/modules/commander/HealthAndArmingChecks/checks/geofenceCheck.cpp
-0.0%      -7  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
  +1.5%      +1  [ = ]       0    task/task_cancelpt.c
-0.2%    -144  [ = ]       0    [Unmapped]
+0.0%     +12  +0.0%    +144    TOTAL
px4_fmu-v6x [Total VM Diff: 152 byte (0.01 %)] 
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%    +152  +0.0%    +152    .text
  +0.1%    +136  +0.1%    +136    [section .text]
  +2.6%     +12  +2.6%     +12    ../../src/modules/commander/HealthAndArmingChecks/checks/geofenceCheck.cpp
  +0.1%      +4  +0.1%      +4    ../../src/modules/ekf2/EKF/yaw_estimator/EKFGSF_yaw.cpp
+0.0%     +56  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -8  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
+0.0%     +23  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
  +0.1%     +27  [ = ]       0    ../../src/modules/commander/HealthAndArmingChecks/checks/geofenceCheck.cpp
-0.0%     -23  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  -0.0%      -1  [ = ]       0    ../../src/modules/commander/HealthAndArmingChecks/checks/geofenceCheck.cpp
  +0.3%      +3  [ = ]       0    task/task_cancelpt.c
-0.0%     -29  [ = ]       0    .debug_loc
  -2.0%     -29  [ = ]       0    ../../src/modules/commander/HealthAndArmingChecks/checks/geofenceCheck.cpp
-0.0%      -7  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
  +1.5%      +1  [ = ]       0    task/task_cancelpt.c
-0.2%    -152  [ = ]       0    [Unmapped]
+0.0%     +12  +0.0%    +152    TOTAL

Updated: 2025-04-25T11:27:06

@TomasTwardzik
Copy link
Copy Markdown
Contributor Author

TomasTwardzik commented Apr 14, 2025

Pre fix:
image
image

Post fix:
image
image

@TomasTwardzik TomasTwardzik requested a review from sfuhrer April 14, 2025 09:00
sfuhrer
sfuhrer approved these changes Apr 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the diligent explanation, looks very reasonable to me.

@TomasTwardzik TomasTwardzik force-pushed the mavlink_geofence_messag_length_fix branch from d908237 to 1438219 Compare April 25, 2025 11:21
@TomasTwardzik TomasTwardzik marked this pull request as ready for review April 25, 2025 11:50
@dakejahl dakejahl merged commit 94bbd2d into main Apr 25, 2025
65 of 67 checks passed
@dakejahl dakejahl deleted the mavlink_geofence_messag_length_fix branch April 25, 2025 18:20
mrpollo pushed a commit that referenced this pull request Nov 24, 2025
@TomasTwardzik @mrpollo
[fix]reducing length of Geofence vilations to prevent STATUSTEXT mess…
9840185 
…age length overrun (#24719)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfuhrer sfuhrer sfuhrer approved these changes

@dakejahl dakejahl dakejahl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TomasTwardzik @sfuhrer @dakejahl