System seems to be the convention in gz so I followed the same pattern. We could call it SystemPlugin but all plugins are system plugins so 🤷
https://gazebosim.org/api/sim/8/createsystemplugins.html
https://github.com/gazebosim/gz-sim/tree/gz-sim9/test/plugins

What would be the requirements for the mavlink camera manager? Is there a way to integrate with CI or some standard tests to run against QGC?

System seems to be the convention in gz so I followed the same pattern. We could call it SystemPlugin but all plugins are system plugins so 🤷

Fair enough 🤷

What would be the requirements for the mavlink camera manager? Is there a way to integrate with CI or some standard tests to run against QGC?

It just needs to comply with the mavlink camera protocol: https://mavlink.io/en/services/camera.html
In gazebo classic, this was done from a plugin: https://github.com/PX4/PX4-SITL_gazebo-classic/blob/main/src/gazebo_camera_manager_plugin.cpp

I was wondering if it would be better to make it a px4 module, or we keep it inside gazebo but I guess it is better than no plugin either way.

@DonLakeFlyer from the QGC perspective what else would be nice to have for testing?

Ooh, nice thanks. I'll have to think about that a bit to see if there are other things that would help. Remote ID testing comes to mind, but not sure if that's possible.

The other thing is that I can't seem to get MAV_1_BROADCAST to work. I always need to futz the startup scripts manually to get UDP to be in broadcast mode.