SIM: MPC: add two x500 lidar airframes#23879
Merged
Conversation
1 task
…r sensors and their orientation
f43eeec to
ef72892
Compare
dakejahl
reviewed
Nov 4, 2024
Co-authored-by: Jacob Dahl <37091262+dakejahl@users.noreply.github.com>
Co-authored-by: Jacob Dahl <37091262+dakejahl@users.noreply.github.com>
Contributor
|
For docs, we want to know how they are used/invoked, what they allow you to test when using that frame (such as terrain following, collision detection etc) [i.e. if enabled by default], and any limits - i.e. rangefinder max/min distance. |
4 tasks
This was referenced Nov 12, 2024
Jaeyoung-Lim
approved these changes
Nov 13, 2024
Member
Jaeyoung-Lim
left a comment
There was a problem hiding this comment.
Overall, looks good to me!
Just a question, is it possible to have both a 2d lidar and a lidar for a distance sensor?
Member
Author
|
@Jaeyoung-Lim yea. This should be possible, as the two publish to different topics, and GZBridge is able to differentiate them by that. |
JoelJ18
pushed a commit
to microstrain-robotics/PX4-Autopilot
that referenced
this pull request
Jan 27, 2025
* add two x500 lidar airframe, including the gazebo bridge for the lidar sensors and their orientation * Update src/modules/simulation/gz_bridge/GZBridge.cpp Co-authored-by: Jacob Dahl <37091262+dakejahl@users.noreply.github.com> * Update src/modules/simulation/gz_bridge/GZBridge.hpp Co-authored-by: Jacob Dahl <37091262+dakejahl@users.noreply.github.com> * update submodule --------- Co-authored-by: Jacob Dahl <37091262+dakejahl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly Tracked in #23602
To be merged only when following PR is merged
other relevant PR's
Overview
This PR Adds two X500 models, one with a front facing rangefinder for collision prevention, and one down facing lidar for normal rangefinder use case testing.
I also renamed the x500_lidar to x500_lidar_2d, to better differentiate the three
Changes:
New Models:
x500_lidar_frontx500_lidar_frontChanges:
x500_lidar-->x500_lidar_2dChangelog Entry
For release notes:
Test coverage
Open Tasks: