Allowing instance_start to be used properly with new actuator output types#23616
Merged
Allowing instance_start to be used properly with new actuator output types#23616
Conversation
…d in actuator yaml files they parameters are able to be used
dagar
approved these changes
Aug 26, 2024
Ali-barari
pushed a commit
to Ali-barari/AvesAID
that referenced
this pull request
Apr 29, 2025
…ce start is changed in actuator yaml files they parameters are able to be used (PX4#23616) Co-authored-by: Luca Scheuer <luca.scheuer@iq-control.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
I found that when instance start is set in an actuator output yaml to something besides 1 then the parameters don't match the expected from mixer_module.cpp. I submitted an issue here
Fixes #23615
Solution
Changelog Entry
For release notes:
Alternatives
We could also remove the functionality that is already available in the metadata generator, but that seems silly as this is only adding consts that shouldn't affect size or speed.
Test coverage
Context
From the issue, when instance start is 0. This is nice if the channels match an ID in the output device so that there isn't confusion about off by 1 labeling.
Before:

After:
