Test for Optical Flow checks correct camera position#23266
Merged
Conversation
sfuhrer
reviewed
Jul 11, 2024
bresch
previously approved these changes
Jul 15, 2024
Co-authored-by: Mathieu Bresciani <brescianimathieu@gmail.com>
…owTest.cpp Co-authored-by: Mathieu Bresciani <brescianimathieu@gmail.com>
sfuhrer
requested changes
Jan 20, 2025
…owTest.cpp Co-authored-by: Silvan Fuhrer <silvan@auterion.com>
sfuhrer
approved these changes
Jan 22, 2025
Contributor
sfuhrer
left a comment
There was a problem hiding this comment.
Looks clean now, thanks for your contribution!
JoelJ18
pushed a commit
to microstrain-robotics/PX4-Autopilot
that referenced
this pull request
Jan 27, 2025
…PX4#23266) * Test for Optical Flow checks correct camera position * Formatting fixed * Update src/modules/sensors/vehicle_optical_flow/test/CMakeLists.txt Co-authored-by: Mathieu Bresciani <brescianimathieu@gmail.com> * Update src/modules/sensors/vehicle_optical_flow/test/VehicleOpticalFlowTest.cpp Co-authored-by: Mathieu Bresciani <brescianimathieu@gmail.com> * Update src/modules/sensors/vehicle_optical_flow/test/VehicleOpticalFlowTest.cpp Co-authored-by: Silvan Fuhrer <silvan@auterion.com> * For test GIVEN/WHEN/THEN added --------- Co-authored-by: Mathieu Bresciani <brescianimathieu@gmail.com> Co-authored-by: Silvan Fuhrer <silvan@auterion.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
OpticalFlow tests coverage improved with additional tests.
Fixes #{Github issue ID}
Solution
New test 'VehicleOpticalFlowTest' which checks camera orientation for Optical Flow.
Changelog Entry
For release notes:
Test coverage
VehicleOpticalFlowTest - new test