Solving Segmentation Fault on "differential_drive stop" (Patch for issue #22818)#23170
Conversation
When calling "differential_drive stop" a missing return statement was causing a segmentation fault due to access to already freed memory.
MaEtUgR
approved these changes
Jun 3, 2024
Member
MaEtUgR
left a comment
There was a problem hiding this comment.
You're absolutely right. run() also immediately ends in this case in all other modules I checked. Sorry it took so long and thanks for contributing the fix 🙏
Contributor
Author
|
@MaEtUgR , thanks, you the best |
chiara-septentrio
pushed a commit
to flyingthingsintothings/PX4-Autopilot
that referenced
this pull request
Jul 3, 2024
chiara-septentrio
pushed a commit
to flyingthingsintothings/PX4-Autopilot
that referenced
this pull request
Jul 4, 2024
Ali-barari
pushed a commit
to Ali-barari/AvesAID
that referenced
this pull request
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
When calling "differential_drive stop" during a simulation involving a robot with differential drive like r1_rover, a missing return statement in DifferentialDrive.cpp was causing a segmentation fault due to access to already freed memory.
Fixes issue #22818
Solution
Adding a return statement after line 68 solves the issue.